Hi,

It's a good thing to have the copy address functionality in Commerce Core, but I'm wondering why it has been done has a variable, and not, like other pane settings, into the hook_commerce_checkout_pane_info(), so that it could be altered conditionally?

I think that would allow developers to enable or disable it depending on some use cases (there are some cases where I don't display one Customer Profile pane, although it's the one that should be used as a source for the copy when it's there).

Why do you think of this proposition?

Comments

rszrama’s picture

rszrama commented

I suppose we could do this by reading the variables once in the checkout pane info array and referencing that data when building the checkout pane to determine whether or not to include the copy address functionality. I'm not sure it's helpful, though. At least as is you can still use hook_form_alter() to disable the address copy functionality on a form where you don't want it, but if we changed to an approach governed by the checkout pane, there'd be no one to enable it through a form alter without duplicating the code from the Customer module.

jsacksick’s picture

jsacksick commented
Issue summary: View changes
Status: Active » Closed (won't fix)

D7 is EOL, closing this.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.