The HTML order template has some CSS issues that need to be fixed :

  • Inline the logo and "thanks for your order"
  • Same blue color for order number and "contact us" than the "view your order" button
  • The address should be displayed the same way for all lines
  • Add spacing on top and bottom of the items table
  • 1 line per subtotal and price under the table
CommentFileSizeAuthor
#3 Selection_029.png49.49 KBRoySegall
Current HTML order template56.94 KBGuGuss
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GuGuss’s picture

GuGuss CreditAttribution: GuGuss commented
Assigned: Cookiz » amitaibu
RoySegall’s picture

RoySegall CreditAttribution: RoySegall commented
Assigned: amitaibu » RoySegall
RoySegall’s picture

RoySegall CreditAttribution: RoySegall commented
Status: Active » Needs review
FileSize
Selection_029.png49.49 KB

I applied the fixes. The gerrit page: https://code.drupalcommerce.org/141.

Also, attached a screen shot.

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Needs review » Needs work

Changing status per Augustin's code review in gerrit.

GuGuss’s picture

GuGuss CreditAttribution: GuGuss commented

Need some quick fixes :

  • More spacing between "view your order" and "Ship to"
  • More spacing between the address and "items in your order"
  • items in your order => Items in your order
  • ship to => Ship to
GuGuss’s picture

GuGuss CreditAttribution: GuGuss commented
Status: Needs work » Fixed

Commit has been merged.

GuGuss’s picture

GuGuss CreditAttribution: GuGuss commented
Assigned: RoySegall » theo_
Status: Fixed » Active

It seems that no email is sent to the non-admin user after an order is proceed !

@theo : can you check why ?

GuGuss’s picture

GuGuss CreditAttribution: GuGuss commented
Priority: Normal » Major
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Assigned: theo_ » itamar

Re-assign.

itamar’s picture

itamar CreditAttribution: itamar commented
Assigned: itamar » theo_

Order-completed email does get sent to normal authenticated users when I try it locally. I'm unable to reproduce the issue.

theo_’s picture

theo_ CreditAttribution: theo_ commented
Priority: Major » Normal
Status: Active » Needs review

The problem was that, we were trying to send a mail to the order's owner before assigning the owner to the order ...

Juste updated the weight of the rule rules_commerce_order_message_order_notification to happen after user creation.

https://code.drupalcommerce.org/212

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Needs review » Fixed

Merged, good job.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.