Closed (fixed)
Project:
Front Page
Version:
5.x-1.9
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Aug 2007 at 20:41 UTC
Updated:
29 Aug 2007 at 12:18 UTC
Jump to comment: Most recent file
I checked front_page.module with the latest version of code review by coder.module, and there were several dozen formatting issues. The suggested patch fixes this, and does nothing else.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | front_page.module_2.patch | 22.79 KB | fgm |
| #8 | front-1-28-2-1_1.patch | 30.93 KB | fgm |
| #7 | front-1-28-2-1_0.patch | 30.93 KB | fgm |
| #4 | front-1-28-2-1.patch | 31.54 KB | fgm |
| front_page.module_1.patch | 27.76 KB | fgm |
Comments
Comment #1
fgmForgot to set status.
Comment #2
beginner commentedThanks.
Why is this filed for D4.7?
Comment #3
beginner commentedOk, I see.
The patch is against version 1.63 of front_page.module.
The current head version is v 1.71.
I had already cleaned some coding standard problems, but not all. What would be useful is a patch against HEAD.
I could apply the patch for 4.7, but that version is not really supported anymore, and the patch is not valid for HEAD.
Comment #4
fgmIndeed, the patch is only for v1.63, which I thought to be the latest version in the 4.7 branch, as some "polish" for the last stable version in that branch. However, I just noticed there is a more recent version, much higher in the tree, v1.28.2.1, tagged 4-7--4.1. The new patch attached to this comment applies to v1.28.2.1
I can also make one for the D5 branch, of course. On which version should I base it ? 1.72 ? But I'd still like to have the 4.7 version include it (my current largest site is 4.7-based and will be skipping directly to 6, for which there is no current branch for this module).
I didn't remember Dublin Drupaller had added me to the dev list for this module, though :-)
Comment #5
fgmForgot to set status again.
Comment #6
beginner commentedYes, the branching for the earlier releases were not properly done. In order to fix a minor bug with the 4.7 version, I had to create a branch from a much earlier version.
So, v1.28.2.1 is the right version to patch.
I couldn't apply the patch because of non-standard line endings. See:
http://drupal.org/patch/create#unix-line-endings
Current HEAD works for D5, and it will become D6. If you want those fixes in the future D6, HEAD/D5 has to be patched first.
Comment #7
fgmHere is a version with LF endings. Does it apply ?
Comment #8
fgmHere is a version with LF endings. Does it apply ?
Comment #9
beginner commentedCommitted to the 4.7 branch. Thanks.
We need the same for HEAD.
Comment #10
beginner commentedComment #11
fgmThanks for RTBCing the 4.7.x patch.
Here is a version rerolled for 1.72.
Comment #12
beginner commentedI see many changes from 'TRUE' to 'true'.
Is that really part of the standard?
I cannot find anything related here:
http://drupal.org/coding-standards
Comment #13
beginner commentedI reviewed the whole patch, and I notice with some satisfaction that it is both much shorter than the patch for 4.7, and especially much more readable! I remember I had fixed much of the coding style earlier.
I committed the patch: everything looked ok.
I am still puzzled by the TRUE -> true changes, though.
I prefer 'TRUE' and I don't see anything in the standards that say we should use 'true' instead. Maybe 'TRUE' is reserved for SQL, but it doesn't say so in the guidelines.
I'd like to know: were those changes suggested by coder? I also NEED to know, so that I code in the proper way later.
Anyway, in order not to waste time on minor issues, I have committed the whole lot.
Comment #14
beginner commentedAnd thanks a lot fgm for the patches. :)
Comment #15
fgmYes, I prefer TRUE, FALSE, NULL too, as these look like regular constants instead of language builtins, but coder.module suggests the change on performance grounds:
Zend Studio code completion always suggests the lower-case version too. Apparently, these are builtins, where as the upper-case form just happens to resolve to the (lower-case) builtin. But the main php doc uses the upper-case form. Go figure.
FWIW ZendFramework consistently uses the lower-case form.
Comment #16
beginner commentedThanks for the feedback.
I added a comment to the coding standards page:
http://drupal.org/coding-standards#comment-262290
Comment #17
(not verified) commented