The CSS files of this modules is very small. Their is no benefit to try to filter it out when is not used.

The same can be done with JS.

The benefit to load it on every page is you have more chance to get the same CSS across different page.

CommentFileSizeAuthor
#7 extlink-1668670-2.patch922 byteselachlan
#1 External_Links-udate_css_link_to_.info_file-1668670-1.patch981 byteschristiang

Comments

christiang’s picture

christiang commented
Assigned: Unassigned » christiang
Status: Active » Needs review
StatusFileSize
new External_Links-udate_css_link_to_.info_file-1668670-1.patch981 bytes

I update the link to .info file to be used on every page, and remove it from .module file. Im attaching the .patch to be reviewed.

Regards!

gagarine’s picture

gagarine commented

Look ok for me.

elachlan’s picture

elachlan commented
Status: Needs review » Fixed

Committed to Git.

elachlan’s picture

elachlan commented
Version: 7.x-1.9 » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)

Patch needs to be ported to 6.x branch.

quicksketch’s picture

quicksketch
he/him
commented

Just a note, I don't think you can add CSS files in .info in Drupal 6. In D6, only themes had that ability (I think).

elachlan’s picture

elachlan commented

Yeah I think its D7 specific. In D8 we are using hook_library_info().

elachlan’s picture

elachlan commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new extlink-1668670-2.patch922 bytes

Rolled the 6.x patch.

Apparently the .info option works with Drupal 6.

More Info: https://drupal.org/node/171209

elachlan’s picture

elachlan commented
Status: Needs review » Closed (won't fix)

Actually It looks like I am wrong. That link was for themes.