This CSS file is marked as preprocess=false, which means it will not be aggregated with other CSS files resulting in one or two extra HTTP requests (one for the file itself, a second if it causes a block of aggregated CSS files to be split into two).

There is no reasoning mentioned for this behaviour in the file or the commit message, so I presume it was left over from the development of the patch. Original commit: http://drupalcode.org/project/date.git/blobdiff/ce77e0b1d5f678b4ed69618b...

I will attach a patch that removes this option.

CommentFileSizeAuthor
#1 date-css_aggregation-1668240-1.patch480 bytesianthomas_uk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Status: Active » Needs review
FileSize
date-css_aggregation-1668240-1.patch480 bytes

Patch

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented

Is anyone able to review this change?

sorin.eugen’s picture

sorin.eugen CreditAttribution: sorin.eugen commented

We've applied the patch on our projects and works as expected, the jquery.timeentry.css file is aggregated.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good to me.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Reviewed & tested by the community » Fixed

Committed 1cd6ea8 and pushed to 7.x-2.x. Thanks!!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.