It seems like the 'Text for "Other..." option' textfield should be hidden unless the "Allow other option" checkbox is checked. This patches fixes this by using the D7 #states FAPI property. I added a class to the textfield because it seems like the field name (and id) could change if the options_element module is enabled.

CommentFileSizeAuthor
webform-select-or-other-states-1.patch984 bytesjlyon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented

Thanks! I'll give this a shot next time I'm reviewing patches.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Needs review » Fixed

Thanks! Finally committed. Changed "TRue" to "TRUE". Otherwise identical.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.