Our job and job item entities are management entities, normal users don't view them, only those with permissions to actually do something with them.
Because of that are the view pages of both currently totally useless. I would suggest to move checkout/checkoutInfo stuff to view instead of an additional tab. Then we can introduce a normal edit tab that is only for administrators where they can actually edit the job outside of the normal checkout -> review -> accept workflow.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | merge-view-manage-1667648-12.patch | 10.75 KB | berdir |
| #7 | merge-view-manage-1667648-7.patch | 9.11 KB | berdir |
| #6 | merge-view-manage-1667648-6.patch | 6.73 KB | berdir |
| #4 | merge-view-manage-1667648-4.patch | 6.22 KB | berdir |
| #2 | merge-view-manage-1667648-2.patch | 6.22 KB | berdir |
Comments
Comment #1
berdirOr, a bit a different approach but the same result, we say that we don't need view and group everything into edit.
For example, look at rules.. you never view a rule, you always immediately edit it, there is no separate read-only view page. Same for wysywig profiles, views (you can view views displays that are displayed on the page, but that's not the same).
What makes this rather obvious is that there is no separate view permission. Nobody can only view jobs and not edit them.
Comment #2
berdirHere's a first patch that merges the manage and view pages.
I think this is much better although it's a bit tricky with the inter-dependencies between tmgmt and tmgmt_ui but I don't really see a way around it.
Let's see what the tests have to say about it.
Comment #4
berdirNeed to use entity_ui_get_form(), it seems. I guess the module exists check would then actually not be necessary.
Comment #6
berdirThis should allow the tests to pass.
Comment #7
berdirUpdated view/checkout links to manage/submit and only show one of them as suggested in #1441648: UI: TMGMT Core, also fixed the default job overview to do a left join instead of inner join to the translators, currently jobs without a selected translator were not listed.
Comment #9
cgalli commentedapplied and tested
- all translation jobs ever started but never submitted showed up in the jobs list-> left join works
- merging of view/manage works (this is going to be a BIG windows when handling jobs with many items)
documentation will follow
Comment #10
cgalli commentedDocumentation is adapted (to the patch not yet committed)
Comment #11
berdirThanks for testing, still need to fix the tests first.
Big window shouldn't be a problem and there is no difference to before, the view should automatically start to page if there are more than N (10?) items.
Comment #12
berdirOk, this should fix the tests.
Comment #13
berdirOk, this should fix the tests.
Comment #14
berdirCommited.