Hi nedjo,
Thanks for the module! I see your on the Tabs Roll...

I've enabled the module, and I'm using the latest Tabs (5.x-1.x-dev), but when I set the View type to any of the Views Tabs I get a blank view. Bug or support issue? ;)

  $view = new stdClass();
  $view->name = 'Views_Tabs';
  $view->description = 'Views Tabs demo';
  $view->access = array (
);
  $view->view_args_php = '';
  $view->page = TRUE;
  $view->page_title = '';
  $view->page_header = '';
  $view->page_header_format = '1';
  $view->page_footer = '';
  $view->page_footer_format = '1';
  $view->page_empty = '';
  $view->page_empty_format = '1';
  $view->page_type = 'tabs_node';
  $view->url = 'tabs';
  $view->use_pager = FALSE;
  $view->nodes_per_page = '10';
  $view->sort = array (
  );
  $view->argument = array (
  );
  $view->field = array (
  );
  $view->filter = array (
    array (
      'tablename' => 'node',
      'field' => 'status',
      'operator' => '=',
      'options' => '',
      'value' => '1',
    ),
    array (
      'tablename' => 'node',
      'field' => 'type',
      'operator' => 'OR',
      'options' => '',
      'value' => array (
  0 => 'story',
),
    ),
  );
  $view->exposed_filter = array (
  );
  $view->requires = array(node);
  $views[$view->name] = $view;

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Hmm. Thanks for the note. I imported your view on my test site and it works fine.

Can you view the source of the page and confirm if the output is there? I.e., is there content that looks something like this:

<div class='view view-Views-Tabs'><div class='view-content view-content-Views-Tabs'><div class="drupal-tabs">
<ul class="anchors">

If so, the issue would appear to be on the client side (e.g., the JS or CSS).

Could you also try the tabsexample module included with the 5.x dev download? Enable it and navigate to /tabsexample. Do the tabs display there?

Thanks.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Title: When 'Views Tabs' is enabled the view is blank » Tabs example doesn't work
Project: Views Tabs » Javascript Tools
Component: Code » Tabs

Ok, the Tabs example doesn't work.
I've tried it with a clean installation, JStools (jstools 5.x-1.x-dev, August 7, 2007 - 02:05)

Am I missing something? Thing is that it did work for me few days back, but I think since this latest-latest version it no longer does.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

Forgot to mention that with jstools 5.x-0.6, the Tabs example works Ok.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks for the update. Probably some change I've made to HEAD but not backported to 5.x. I'll try to fix.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

I updated 5.x dev and also posted a new release. Does either of these work for you?

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

Still not working (Last updated: August 9, 2007 - 02:05)

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Working for me. I suspect some other module is interfering.

Please report any Javascript errors.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

This is on a fresh installation, and only this module enabled ;)

Here is the report from Firebug:

Drupal.behaviors has no properties
http://localhost/drupal/modules/jstools/tabs/tabs.js
Line 3
nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Tabs requires Javascript Tools (which declares Drupal.behaviors). Do you have jstools enabled? It shouldn't be possible to enable tabs from the UI without also enabling jstools.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

'Javascript tools' is enabled.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Fixed

Thanks for sticking with this. I'd failed to test with only tabs.module and jstools enabled, and had missed the call in tabs.module to add jstools.js (so tabs worked if another jstools module, e.g., collapsiblock, was enabled, but not on its own).

I've fixed this in HEAD and 5.x dev. Lamentably I posted a new 'stable' release yesterday with this bug in it. I guess I'll wait a bit to see if other bugs show up and then post a new 'stable' release.

drumdance’s picture

drumdance commented

I'm running into this same problem. Can you post the patch?

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)