With this module installed I can't run update.php. I had to turn on errors to diagnose the problem but the short version is that;

update_prepare_d7_bootstrap( ) in update.php [Line #362] calls....
domain_variable_domain_bootstrap_full( ) which eventually calls ....
domain_api( ) which needs the function module_implements() from /includes/module.inc

The problem is that /includes/module.inc is not loaded in update.php until line #385...

*** If I hack domain.module to pull in module.inc, I then get a simular error message as Issue# 1559904***
Call to undefined function variable_realm_initialize() in
/folder/public_html/drupal-7.14/sites/all/modules/domain_variable/domain_variable.module

Is this issue the same as 1559904? Should we block execution the same way? (Check if 'update_check_requirements||update_prepare_d7_bootstrap' is defined???)

--------------------------------------------------------------------------------------------------------------------------------------------

The original error message:
( ! ) Fatal error: Call to undefined function module_implements() in /folder/drupal-7.14/sites/all/modules/domain/domain.module on line 1407
Call Stack
# Time Memory Function Location
1 0.0007 326664 {main}( ) ../update.php:0
2 0.0735 752932 update_prepare_d7_bootstrap( ) ../update.php:362
3 0.0742 819448 drupal_bootstrap( ) ../update.inc:85
4 0.0743 818984 _drupal_bootstrap_configuration( ) ../bootstrap.inc:2156
5 0.0750 823572 drupal_settings_initialize( ) ../bootstrap.inc:2269
6 0.0754 827144 include_once( '/folder/drupal-7.14/sites/default/settings.php' ) ../bootstrap.inc:739
7 0.0756 830308 include( '/folder/drupal-7.14/sites/all/modules/domain/settings.inc' ) ../settings.php:538
8 0.0756 830712 domain_bootstrap( ) ../settings.inc:21
9 0.1499 1936612 _domain_bootstrap( ) ../domain.bootstrap.inc:70
10 0.1499 1937252 _domain_bootstrap_invoke_all( ) ../domain.bootstrap.inc:140
11 0.1499 1938720 call_user_func_array ( ) ../domain.bootstrap.inc:227
12 0.1499 1938972 domain_variable_domain_bootstrap_full( ) ../domain.bootstrap.inc:0
13 0.1499 1938972 _domain_variable_realm_key( ) ../domain_variable.module:56
14 0.1499 1938972 domain_lookup( ) ../domain_variable.module:136
15 0.1824 2104328 domain_api( ) ../domain.module:1065

CommentFileSizeAuthor
#2 update-php-fix-1650904-2.patch757 bytesbforchhammer

Comments

antony.lovric’s picture

Issue summary: View changes

Updated the Description to include 'update_prepare_d7_bootstrap' as a possible marker that we're updating.

antony.lovric’s picture

Issue summary: View changes

cleanup of description to remove site name

bforchhammer’s picture

I guess we have to add something to prevent or fix execution on update.php pages. There's already code in place to prevent similar errors with drush...

bforchhammer’s picture

Status: Active » Needs review
StatusFileSize
new757 bytes

Here's a patch. Entirely untested at this point.

antony.lovric’s picture

Thanks, that's essentially what I did locally (function_exists('update_prepare_d7_bootstrap' ). Works in development for me.

bforchhammer’s picture

Status: Needs review » Fixed

Commited #2, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

desc cleanup