Bean Usage View

Assigning to me to review.

This is a neat idea but I think I'd rather see this at admin/reports/bean-usage that way it corresponds with other usage type reports.

Agreed.

It'd also be nice if when viewing a bean, we utilized the functions generating the report to show a list of linked nodes that reference it. I believe this was also part of the original intention of the request.

Gui, can you add those two changes?

1.) Put the callback under reports
2.) Provide an additional list of linked nodes on the bean view to show where it is being used as a blockreference so a user could jump to that node right away.

Can we get a screenshot?

I had a quick look over this code and it seems to assume that everyone using BEAN will be using blockreference.module. The hook_menu implementation and other places that implement blockreference specific functionality need to be wrapped in if (module_exists('blockreference')) { ... } blocks to avoid introducing a hard dependency for the module.

The patch from #11 didn't apply cleanly to me. It looks like it might have been diff'd from an older version of bean.

The attached patch has been diff'd from the latest 7.x-1.x-dev.

I've put the usage into a separate module so we can easily add context and block admin usage later. This also makes it easier to add the blockreferences dependency.

I also pulled some (not all) of the queries out.

A couple of things for Guito339 to add just to /admin/reports/bean/usage callback, please:

1. Paginate the bean usage results as some sites (like Energy.gov) have thousands of beans
2. Make table headers sortable
3. Pull in bean title as column between bean type and entity reference
4. Provide filter for bean types

It may be easier to make the report a view as this will accomplish all of the above, but you'll then have to refactor your code to be a views handler. If it's a default view, this would also allow users to add other fields as they see fit. It's up to you.

Forgot patch

I applied the patch on a vanilla install. Received a few errors:

Notice: Trying to get property of non-object in bean_usage_output() (line 102 of ../bean/bean_usage/bean_usage.module).
Notice: Trying to get property of non-object in bean_usage_output() (line 103 of ../bean/bean_usage/bean_usage.module).
Notice: Undefined index: filter in bean_usage_output() (line 110 of ../bean/bean_usage/bean_usage.module).
Notice: Undefined index: sort in bean_usage_output() (line 155 of ../bean/bean_usage/bean_usage.module).
Notice: Undefined index: filter in bean_usage_filters() (line 41 of ../bean/bean_usage/includes/bean_usage.forms.inc).
Strict warning: Only variables should be passed by reference in bean_usage_output() (line 299 of ../bean/bean_usage/bean_usage.module).

Once these are cleaned up, should be fine.

Looks good. Pulled in.

http://drupalcode.org/project/bean.git/commit/d34eb7d