disable twitter signin buttons on login forms.

Works for me, just one small whitespace error.

twitter_signin.patch:11: trailing whitespace.
    if(variable_get('twitter_signin_login',TRUE)){
warning: 1 line adds whitespace errors.

Minor revision. The above patch applied OK, when applied from the command line and placed in the Drupal root. However it wouldn't work when applied from a Drush Make file.

All I did was remove the absolute paths and the white space. This patch did apply with no errors from a Drush Make file.

Just a minor thing:
Maybe complete the description, as it will also add the button to the user login block form:
"Add button to user login form and user login block".

But this is also something I wanted to add. Thanks for committing this patch! It's a bit annoying the module does the alter by default. I need another button (different lay-out and text on the button). So it would be nice to turn off the alter by the twitter signin module and do my own alter to add a custom button.

I guess this can be won't fixed as this branch is no longer supported.

Is there any reason not to update this patch to work with the latest version?

There's an offset, but this patch does actually apply to 5.8, so it just needs to be rerolled to get the line numbers right. I can confirm it works in 5.8.

However, it doesn't do what I was hoping (I didn't read the issue carefully enough) which was to allow me to display it on the login page but not in the login block. So it would be great if there could actually be two checkboxes, one for user login form and one for user login block.

Rerolled.

Rerolled, updated a little bit and ported to 7.x-6.x.

Ported to 7.x-5.x.

Some additional small improvements. For 7.x-6.x.

Ported to 7.x-5.x.

Ported to 6.x-5.x.

Committed.