Convert chessboard_filter tests to PSR-0

See #1513210: Meta: Start converting module provided classes to PSR-0.

Comment	File	Size	Author
#17	chessboard-tests-to-PSR-0-1643340-17.patch	993 bytes	eric_a
#14	chessboard-tests-to-PSR-0-1643340-14.patch	957 bytes	eric_a
#12	chessboard-tests-to-PSR-0-1643340-12.patch	47.24 KB	eric_a
#10	chessboard-tests-to-PSR-0-1643340-10.patch	47.59 KB	eric_a
#9	chessboard-tests-to-PSR-0-1643340-9.patch	1.19 KB	eric_a
#8	chessboard-tests-to-PSR-0-1643340-8.patch	1.04 KB	eric_a
#5	chessboard-tests-to-PSR-0-1643340-5.patch	678 bytes	eric_a
#4	chessboard-tests-to-PSR-0-1643340-4.patch	1.98 KB	eric_a
#3	chessboard-tests-to-PSR-0-1643340-3.patch	1.48 KB	eric_a
#1	chessboard-tests-to-PSR-0-1643340-1.patch	47.46 KB	eric_a

Comments

Comment #1

eric_a commented 17 June 2012 at 19:04

Status:

Active

» Needs review

Status	File	Size
new	chessboard-tests-to-PSR-0-1643340-1.patch	47.46 KB

Log in or register to post comments

Comment #2

eric_a commented 18 June 2012 at 06:12

#1: chessboard-tests-to-PSR-0-1643340-1.patch queued for re-testing.

Log in or register to post comments

Comment #3

eric_a commented 19 June 2012 at 05:40

Status	File	Size
new	chessboard-tests-to-PSR-0-1643340-3.patch	1.48 KB

It turns out that the testbot is broken with regards to PSR-0 tests in contrib: #1642478: PSR-0 based tests for contrib modules aren't executed.

Anyway,here's an improved version.

Log in or register to post comments

Comment #4

eric_a commented 7 July 2012 at 12:25

Status	File	Size
new	chessboard-tests-to-PSR-0-1643340-4.patch	1.98 KB

Log in or register to post comments

Comment #5

eric_a commented 7 July 2012 at 14:10

Status	File	Size
new	chessboard-tests-to-PSR-0-1643340-5.patch	678 bytes

Pushed #4 to 8.x.-2.x.

Patch attached to remove the workaround when the PIFR issue is fixed. Note that until then this will produce 0 passes, just like the earlier patches.

Log in or register to post comments

Comment #6

eric_a commented 15 July 2012 at 09:47

#5: chessboard-tests-to-PSR-0-1643340-5.patch queued for re-testing.

Log in or register to post comments

Comment #7

eric_a commented 15 July 2012 at 10:01

Version:	8.x-2.x-dev	» 7.x-2.x-dev
Status:	Needs review	» Patch (to be ported)

Committed and pushed #5 to 8.x-2.x. Moving to 7.x-2.x.

Log in or register to post comments

Comment #8

eric_a commented 22 July 2012 at 14:05

Status:

Patch (to be ported)

» Needs review

Status	File	Size
new	chessboard-tests-to-PSR-0-1643340-8.patch	1.04 KB

Log in or register to post comments

Comment #9

eric_a commented 22 July 2012 at 14:10

Status	File	Size
new	chessboard-tests-to-PSR-0-1643340-9.patch	1.19 KB

Log in or register to post comments

Comment #10

eric_a commented 23 July 2012 at 00:19

Status	File	Size
new	chessboard-tests-to-PSR-0-1643340-10.patch	47.59 KB

Log in or register to post comments

Comment #11

23 July 2012 at 00:21

Status:

Needs review

» Needs work

The last submitted patch, chessboard-tests-to-PSR-0-1643340-10.patch, failed testing.

Log in or register to post comments

Comment #12

eric_a commented 23 July 2012 at 01:27

Status:

Needs work

» Needs review

Status	File	Size
new	chessboard-tests-to-PSR-0-1643340-12.patch	47.24 KB

Log in or register to post comments

Comment #13

eric_a commented 23 July 2012 at 08:10

Status:

Needs review

» Fixed

Committed and pushed to 7.x-2.x.

Log in or register to post comments

Comment #14

eric_a commented 30 July 2012 at 16:20

Status:

Fixed

» Needs review

Status	File	Size
new	chessboard-tests-to-PSR-0-1643340-14.patch	957 bytes

Log in or register to post comments

Comment #15

eric_a commented 28 August 2012 at 20:30

Status:

Needs review

» Fixed

Log in or register to post comments

Comment #16

11 September 2012 at 20:31

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #17

eric_a commented 3 April 2013 at 09:52

Status:

Closed (fixed)

» Needs review

Status	File	Size
new	chessboard-tests-to-PSR-0-1643340-17.patch	993 bytes

#1693398: Allow PSR-0 test classes to be used in D7 (followups) went in.

Let's remove the D7 specific hack.

Log in or register to post comments

Comment #18

eric_a commented 3 April 2013 at 10:07

Status:	Needs review	» Fixed
Issue tags:		+Needs backport to D7

Pushed #17 to 7.x-2.x.

Log in or register to post comments

Comment #19

17 April 2013 at 10:10

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments