Three places in user_edit_form.inc do SQL queries on {user} instead of the correct {users}. This results in Ajax errors.

Lines 97, 144, and 147.

Also, on line 144 "WHEREuid" should be changed to "WHERE uid" (needs a space).

I'll do a patch when I get back to my main computer...

CommentFileSizeAuthor
#3 table_name_should_be-1638394-3.patch1.55 KBsidharrell
#1 table_name_should_be-1638394-1.patch1.55 KBsidharrell

Comments

sidharrell’s picture

sidharrell commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new table_name_should_be-1638394-1.patch1.55 KB

confirmation that this patch fixes the issue by nerconi in #drupal-support

dawehner’s picture

dawehner
Primary language German
commented

Needs a reroll after #2446121: SQL error in plugins/contexts/user_edit_form.inc went in.

sidharrell’s picture

sidharrell commented
StatusFileSize
new table_name_should_be-1638394-3.patch1.55 KB

don't know what happened to patchutils, but interdiff chocked for me.

Status: Needs review » Needs work

The last submitted patch, 3: table_name_should_be-1638394-3.patch, failed testing.

sidharrell’s picture

sidharrell commented
Version: 7.x-1.0 » 7.x-1.x-dev
Status: Needs work » Needs review

sidharrell queued 3: table_name_should_be-1638394-3.patch for re-testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented

wow, I would really love to write some test, if time permits.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Fixed

Looks good. fixed!

  • japerry committed 6ad8c78 on 7.x-1.x authored by sidharrell 
    Issue #1638394 by sidharrell: Table name should be {users} not {user}

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.