Over at http://drupal.org/node/71606, pwolanin posted http://drupal.org/files/issues/sanity_2.patch to clean up the mess with project_issue_page() and a ton of menu callbacks that call this monster function, instead of separate callbacks for separate menu items that do separate things.

I'd rather just review and handle this patch separately from what #71606 is about.

CommentFileSizeAuthor
#4 sanity_3.patch2.46 KBpwolanin

Comments

pwolanin’s picture

subscribe

dww’s picture

Status: Needs review » Fixed

Reviewed and tested heavily. All is well. Committed to HEAD. Thanks!

dww’s picture

Category: task » bug
Status: Fixed » Active

Ugh. This broke something that escaped my testing, but which wwwebernet reported in IRC.
If you went to project/issues, selected a given project in the dropdown and pressed "Search", it would redirect you to project/issues/user/.... :(

So, I just temporarily reverted the change on d.o. But, we need to fix this ASAP, if possible. Otherwise, I should just back out the commit from CVS entirely, but that'd be a shame, since everything else seemed to be an improvement...

pwolanin’s picture

Status: Active » Needs review
StatusFileSize
new2.46 KB

ahh, alive again...

Here's a follow-on patch.

the problem was that the default value for the argument was 0, and (0 == 'user') is TRUE (oddly enough) since PHP casts to int most strings as zero

dww’s picture

Status: Needs review » Fixed

Thanks, Peter. Even more local testing, then deployed on d.o, cleared the menu cache, and tested on the live site. As far as I can tell, everything's now happy. Phew. ;)

dww’s picture

Status: Fixed » Active

Nope, still not right. :( See http://drupal.org/node/163874. Ugh, this is what I get for trying to deal with dozens of bugs and problems simultaneously, I get hasty and don't do as thorough a job as usual. Alas. Reverted to the revisions before either of these patches on d.o again, pending a better patch here. I'm not going to commit and deploy onto d.o anything else in here until someone else reviews and tests it, since I'm clearly not upto my usual abilities... ;)

pwolanin’s picture

sorry - will try to get back to it.

hunmonk’s picture

Category: bug » task
Status: Active » Postponed

this is not a bug, but a task IMO -- and one that we can more effectively solve in 5.x-2.x

dww’s picture

Status: Postponed » Closed (won't fix)

All this nasty is gone in D6 now that we're using views. project_issue_page() no longer exists. ;) I have no interest in cleaning up the insanity in the D5 branch.