Mobile Tools and Mobile Tools Browscap currently support different device groups. There is no reason why they shouldn't support the same device groups.

CommentFileSizeAuthor
#4 mobile_tools-Do_not_use_t_in_mt_browscap_device_groups-1632434-4.patch1.31 KBDrave Robber
#1 synchronize-supported-device-groups-1632434-1.patch1.42 KBdevin carlson

Comments

devin carlson’s picture

devin carlson commented
Status: Active » Needs review
StatusFileSize
new synchronize-supported-device-groups-1632434-1.patch1.42 KB

A patch to make Mobile Tools and Mobile Tools Browscap support the same device groups.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Committed to 6.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Drave Robber’s picture

Drave Robber commented
Status: Closed (fixed) » Needs review
StatusFileSize
new mobile_tools-Do_not_use_t_in_mt_browscap_device_groups-1632434-4.patch1.31 KB

Wrapping group descriptions in t() leads to:

PHP Fatal error:  Call to undefined function t() in /whatever/sites/all/modules/contrib/mobile_tools/modules/mt_browscap/mt_browscap.module on line 44

The reason is mt_browscap_device_groups() is called by mt_browscap_is_mobile_device() which may be invoked (or rather, is likely to be invoked) in hook_boot() where t() is not available yet.
IMHO, wrapping is not really necessary here (what are we going to translate - 'BlackBerry' to 'BromBeere'?) but using get_t() is also an option.
A patch to remove t() attached.

Drave Robber’s picture

Drave Robber commented
Assigned: devin carlson » Unassigned
Category: task » bug

(this is obviously a bug report now)

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Fixed with http://drupalcode.org/project/mobile_tools.git/commit/5c3450a.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.