Are there any upgrade plans for Drupal 6 or anyone working on it?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Freso’s picture

Assigned: Unassigned » Freso
Status: Active » Needs review
FileSize
1.68 KB

From http://drupal.org/node/132442, it seemed like it would not require too much meddling to get this working on Drupal 6.
A patch attached, Pleroma.info coming up. Not yet tested, so please do.

Freso’s picture

FileSize
309 bytes

And .info file. (Rename to "Pleroma.info" - drupal.org apparently doesn't accept uploads with the ".info" extension.)

Freso’s picture

FileSize
1.68 KB

I just tested on a Drupal 6 CVS install, and PHP (5.2) didn't like the curly brackets, so they're now gone.
I've noticed a few notices though (notice: Undefined variable: content_top in /srv/http/localhost/drupal/themes/Pleroma/page.tpl.php on line 54 plus content_bottom on line 60), but I'm not sure whether these were really there as well in the Drupal 5 version. Either way, since the notices are obviously visible now, they should probably be worked around. Using if empty($content_[top|bottom]) might result in proper behaviour, but I do not wish to go further unless someone gives me the "Go!". It might of course also be that $content_[top|bottom] doesn't exist any more, but I haven't seen this documented anywhere...

Freso’s picture

It should of course be if !empty($content_[top|bottom]) (note the !).

Freso’s picture

Status: Needs review » Needs work

$has_terms in node.tpl.php:11,17 also appears to have problems with definition. Changing the check to !empty($has_terms) instead removes the notice. Neither results in a listing of taxonomy terms.

Freso’s picture

Status: Needs work » Needs review

I guess I need to know whether this patch actually causes behaviour to change or not, before claiming it needs work. So I'll put it back to needs review and hope that someone will take a minute to review it.