PHP Warning: Invalid argument supplied for foreach() in webform_mollom_form_info() [#1621606]

There are a couple of foreach() loops that don't test for valid arrays first, causing the following PHP warnings:

Warning: Invalid argument supplied for foreach() in webform_mollom_form_info() (line 3682 of sites/all/modules/contrib/webform/webform.module).
Warning: Invalid argument supplied for foreach() in webform_mollom_form_info() (line 3693 of sites/all/modules/contrib/webform/webform.module).

Simple fix, obviously. Patch to follow.

Comment	File	Size	Author
#8	webform_mollom_form_list1621606-8-d7.patch	623 bytes	quicksketch
#8
#8	webform_mollom_form_list1621606-8-d6.patch	611 bytes	quicksketch
#8
#2	webform-php-warning-webform_mollom_form_info-7.x.patch	4.05 KB	acbramley
#2
#1	webform-php-warning-webform_mollom_form_info-1621606-1.patch	4.08 KB	TravisCarden
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

TravisCarden CreditAttribution: TravisCarden commented 7 June 2012 at 20:20

Status:

Active

» Needs review

File	Size
webform-php-warning-webform_mollom_form_info-1621606-1.patch	4.08 KB

Comment #2

acbramley CreditAttribution: acbramley commented 14 August 2012 at 03:28

File	Size
webform-php-warning-webform_mollom_form_info-7.x.patch	4.05 KB

This exists on 7.x-3.x branch too, rolled this patch for that.

Comment #3

TravisCarden CreditAttribution: TravisCarden commented 14 August 2012 at 16:32

Version:

6.x-3.x-dev

» 7.x-3.x-dev

Comment #4

fenstrat

he/him

English

Australia

CreditAttribution: fenstrat commented 17 August 2012 at 21:05

Thanks guys, but I can't replicate this. Is it happening on nodes with empty webforms? Patch looks fine, I'm just trying to understand when $node->webform['components'] and $node->webform['emails'] would not be set.

Comment #5

acbramley CreditAttribution: acbramley commented 19 August 2012 at 20:49

Yeah a webform with no components or emails set is what causes it I believe

Comment #6

TravisCarden CreditAttribution: TravisCarden commented 7 December 2012 at 19:46

Assigned:

TravisCarden

» Unassigned

Comment #7

quicksketch

he/him

CreditAttribution: quicksketch commented 14 June 2013 at 01:50

Status:

Needs review

» Needs work

Hi guys, thanks for this patch. Another way to solve this problem is to simply not include nodes in webform_mollom_form_list() that don't have a record in the "webform" table, since we already keep that table clean of any nodes that don't have any components or e-mails. We did a similar fix in #1562756: Webform "admin/content/webform" page should only show nodes with webform configuration, not all webform-enabled types.