This seemed surprising to me actually. Could someone verify this?
My fix was just to add (Patch sets $node->translation['status'] and $node->translation['retranslate']$node->translate = 0; in tmgmt_node.module.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | tmgmt-reset-outdated-attribute-1619786-1.patch | 491 bytes | ethanethan |
| #2 | tmgmt-reset-outdated-attribute-1619786-0.patch | 654 bytes | ethanethan |
Comments
Comment #1
ethanethan commentedSeems this is anticipated already in translation_node_update (translation.module). Just need to set $node->translation['status'] and/or ['retranslate'].
Comment #2
ethanethan commentedComment #2.0
ethanethan commentedgrammaarrrr
Comment #3
berdirMake sure the comments follow the coding standard, which means a space after //, start with an upper case character and end with a "."
This has one problem. That is, if the source node has changed again, it has the chance of incorrectly changing the flag.
Can we make this configurable? Add an if (variable_get('tmgmt_node_update_status', TRUE) and add a hook_form_alter for http://api.worldempire.ch/api/tmgmt/ui%21includes%21tmgmt_ui.pages.inc/f... in tmgmt_node_ui module, adding checkbox, there are already a few examples there.
Comment #4
ethanethan commentedThis is only run when a translation is saved (successfully), right? In that case isn't the correct status always 'not outdated'?
As for the second part-- if its only used to save translations, the node passing through here is never the source.
Comment #5
berdirConsider this list of events:
- New job created to translate node X to DE
- node X is changed, translations are marked as needing re-translation.
- Original translation comes back, DE node is marked as translation updated.
Also related to #1623402: Option to cancel pending translation jobs when its source content is edited. Not sure how to deal with this.
Comment #6
berdir#4: tmgmt-reset-outdated-attribute-1619786-1.patch queued for re-testing.
Comment #7
berdirCommited, better than not having it I think, we can deal with conflict situations in case they occcur.
Comment #8.0
(not verified) commentedremoved "My fix..." because its misleading. The eventual fix is different.