In views_calc_handler_sort.inc, line 9 starts with "while" but should start with "foreach." Patch in comments.

CommentFileSizeAuthor
#4 views_calc-typo-1618286-4.patch555 bytesjromine
#1 views_calc-typo-1618286-1.patch703 bytesjessepinho
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jessepinho’s picture

jessepinho CreditAttribution: jessepinho commented
FileSize
views_calc-typo-1618286-1.patch703 bytes

Patch.

jromine’s picture

jromine CreditAttribution: jromine commented
Status: Active » Reviewed & tested by the community

This is an obvious typo. Moving to RTBC; tested, works (with Drupal 7.20, Views 7.x-3.5)

Taxoman’s picture

Taxoman CreditAttribution: Taxoman commented

Why isnt this getting committed to -dev at least?

jromine’s picture

jromine CreditAttribution: jromine commented
FileSize
views_calc-typo-1618286-4.patch555 bytes

Re-roll #1 with relative filepaths.

Exploratus’s picture

Exploratus CreditAttribution: Exploratus commented

Patch works for me. Can we get this obvious patch committed?

KarenS’s picture

KarenS CreditAttribution: KarenS commented
Issue summary: View changes

This was fixed in dev a year ago but the zip file is not updating. You can see it in a git checkout.

KarenS’s picture

KarenS CreditAttribution: KarenS commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.