site crss feed added to individual nodes

The code may be wrong, but it's fine to have multiple feeds announced per page. The attached implements a fix:

* Fixes the logic for adding feeds, allowing both the all comments and node-specific feeds on the same page
* Fixes a bug where the wrong variable was checked for showing the vocabulary_list feed
* Adds the site name to all generated feed titles

This updated patch outputs absolute URLs for the feeds, to be consistent with Core.

And another with slightly better naming for the taxonomy feed.

One more. It looks like I had forgotten to update the title and description output with the feed. Before, just the LINK element was updated.

Patch has very straneg/bad artifacts like:

- Comments from the “@vocab” Vocabulary
- Comments from the “@term” Category

etc. These bad UTF chars are not nice, and I don't understand the capitalization mis-sentence. Also, why mix unrelated changes, when we are fixing an issue with mis-linking to RSS feeds?

I just committed a 5.x-2.x dev version of the module, which has this bug fixed as well. The site RSS feed has multiple options on where it should be added, and that's strictly adhered to. Please test that and reopen if you still have issues.

http://drupal.org/cvs?commit=113501

Yeah, I guess I should have taken the naming stuff to a different issue. Sorry about that.

I apologize if this is a stupid question, but isn't there a logic problem in the switch statement in commentrss_menu? The COMMENTRSS_SITE_FRONT_AND_NODE_PAGE case won't work if the /node page isn't the front page, but that's not how the setting is described.

Good catch! You mean to replace:

      case COMMENTRSS_SITE_FRONT_AND_NODE_PAGE:
        if (!drupal_is_front_page() && ($_GET['q'] != 'node')) {
          // Only break if not front page and not node page.
          break;
        }

with:

      case COMMENTRSS_SITE_FRONT_AND_NODE_PAGE:
        if (!drupal_is_front_page() || ($_GET['q'] != 'node')) {
          // Only break if not front page and not node page.
          break;
        }

(note the && replaced with ||), so that it really only breaks if it is not the front page or not the node page?

Exactly.

Committed, thanks!