When i try it on an entity which is not a node, i get :
Notice: Undefined property: Entity::$nid in date_ical_plugin_row_ical_feed->render()

i guess you should look for the proper column in entity_get_info()['entity keys']['id']

thanks :)

CommentFileSizeAuthor
#1 1608738.patch760 bytesmojzis

Comments

mojzis’s picture

mojzis commented
Status: Active » Needs review
StatusFileSize
new 1608738.patch760 bytes

i noticed $id is declared and filled a few lines above, that should be sufficient :)

chaseontheweb’s picture

chaseontheweb
Location USA
commented

#1686642: Combo Patch for 1460058, 1608738 and 1608836 cross-references this issue.

coredumperror’s picture

coredumperror commented

This has been applied and committed to 7.x-1.x-dev, as part of #1686642: Combo Patch for 1460058, 1608738 and 1608836. This will be available in the dev build within a few hours, and the official 7.x-1.2 release some time this week.

However, I strongly suggest upgrading to the 7.x-2.x branch, since 7.x-1.x is in bug-fix only mode now, and will soon be abandoned. If you have any problems with the 7.x-2.x branch, please open a new issue.

coredumperror’s picture

coredumperror commented
Status: Needs review » Closed (fixed)

Oops, forgot to close the issue.