Add Curacao to the country list.

Bounding box info from: http://ws.geonames.org/countryInfo?country=cw

CommentFileSizeAuthor
#10 location_curacao_fixed_comment.patch612 bytesalex liannoy
#8 location_curacao_fixed_comment.patch735 bytesalex liannoy
#5 curacao_location_file.patch620 bytesalex liannoy
location-add-curacao-to-countries.patch960 bytesimclean

Comments

imclean’s picture

imclean commented

It could also be worth getting rid of Netherland Antilles (an) and adding Sint Maarten (sx). I'm not really up with these places politically so perhaps a fresh ISO 3166-2 dump is due sometime soon.

A client of ours required Curacao, hence the patch above.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 6.x-3.x-dev » 7.x-3.x-dev

all feature requests should be rolled against latest 7.x-3.x-dev and after commit can be backported to 6.x branch

Status: Needs review » Needs work

The last submitted patch, location-add-curacao-to-countries.patch, failed testing.

imclean’s picture

imclean commented

Haha, well it was nearly a year ago and the patch is still going strong for us.

It's unlikely I'll be rerolling this one.

alex liannoy’s picture

alex liannoy commented
Issue summary: View changes
StatusFileSize
new curacao_location_file.patch620 bytes

Attached patch with location.cw.inc for Curaçao island.

alex liannoy’s picture

alex liannoy commented
Status: Needs work » Needs review
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work

+ * Returns minimum and maximum latitude and longitude needed to create a bounding box.

This should be shorter then 80 characters. Needs fix.

alex liannoy’s picture

alex liannoy commented
StatusFileSize
new location_curacao_fixed_comment.patch735 bytes

Updated previous patch, decreased comment length.

alex liannoy’s picture

alex liannoy commented
Status: Needs work » Needs review
alex liannoy’s picture

alex liannoy commented
StatusFileSize
new location_curacao_fixed_comment.patch612 bytes

Sorry, I have posted patch with absolute paths. Attached fixed one

  • podarok committed 00b3a34 on 7.x-3.x authored by Lianik 
    Issue #1607092 by Lianik, imclean: Added Curacao to supported countries.
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Fixed

#10 merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.