Search Uninstall does not remove all variables [#160603]

search_uninstall does not delete 'search_cron_limit'. This applies to 5.1 as well, although this patch is against 6.x-dev

Comment	File	Size	Author
#3	search_uninstall_0.patch	566 bytes	Freso
#1	search_uninstall.patch	526 bytes	Freso
	search6_install.txt	255 bytes	nancydru

Comments

Comment #1

Freso commented 28 September 2007 at 23:29

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	search_uninstall.patch	526 bytes

I can reproduce this bug.

The patch doesn't apply:

gentoo-vm drupal6 # patch modules/search/search.install search6_install.txt
patching file modules/search/search.install
Hunk #1 FAILED at 18.
1 out of 1 hunk FAILED -- saving rejects to file modules/search/search.install.rej

The attached re-rolled patch removes the variable on uninstall and thus fixes the bug. And there was much rejoicing. :)

Test procedure:
Install/enable the search module, go to admin/settings/search and change "Items to index per cron" to something other than the default, check the "variable" table in the database that "search_cron_limit" is there, disable and then uninstall the search module, check the "variable" table, apply patch, enable search module and then disable and uninstall module again, check the "variable" table this last time, as "search_cron_limit" should no longer be there! Woohoo!