i added the workbench:state field to my view and then noticed that i no longer was listing any nodes which were not under wbench moderation. Looking at the sql i could see that the join created from adding the field was an inner join; which i think is wrong as it will filter out items which do not join - and as this is simply adding a field; it shouldn't filter.

attached patch fixes

CommentFileSizeAuthor
#9 workbench_moderation-left_join_nid-1601036-9.patch743 bytesashrafabed
#8 workbench_moderation-replace_inner_join_with_left_join-1601036-8.patch485 bytesashrafabed
#1 1601036-views_join.patch866 bytesBevan
workbench_moderation-views_join.patch552 bytesliquidcms

Comments

Bevan’s picture

Bevan commented
StatusFileSize
new 1601036-views_join.patch866 bytes

This patch also allows nodes which have a different current revision to the published revision to be included.

Bevan’s picture

Bevan commented
Status: Active » Needs work

Oh, I see from #1361210: 'Workbench moderation: current' views filter does not list all content that the better way to do that is to create a view based on the node_revision table.

As for the original patch, "left" should be capitals.

Bevan’s picture

Bevan commented

Related: #1300616: Node views with duplicate results when using fields from "workbench_moderate_node_history"

Bevan’s picture

Bevan commented
Title: Views handler uses wrong join » Views: Use LEFT JOIN not INNER
peterx’s picture

peterx commented

Patch #1 fixed problem in Workbench Moderation 7.x-1.1 then I installed 7.x-1.2 and it needs the same patch.

hass’s picture

hass commented

Duplicate of #1781744: Draft and Needs review pages are broken?

Taxoman’s picture

Taxoman commented
Status: Needs work » Closed (duplicate)
ashrafabed’s picture

ashrafabed
he
Primary language English
commented
Issue summary: View changes
StatusFileSize
new workbench_moderation-replace_inner_join_with_left_join-1601036-8.patch485 bytes

I needed the most recently attached patch to change the inner join to a left join on the current dev branch.

ashrafabed’s picture

ashrafabed
he
Primary language English
commented
StatusFileSize
new workbench_moderation-left_join_nid-1601036-9.patch743 bytes

The attached patch combines the previous patch (LEFT JOIN not INNER), with a patch for joining on nid rather than vid, because the two patches conflict.

rv0’s picture

rv0 commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Closed (duplicate) » Active

the Patch in #8 works fine on 7.x-1.x branch. Thanks
Re-opening this old issue, would be nice to have this committed (unless there's a good reason not to?)

The linked "duplicate" seems to handle something else.
The patch in #9 I don't understand, is it related to another issue?

ashrafabed’s picture

ashrafabed
he
Primary language English
commented

The patch in #9 should be ignored as it includes something that has already been merged into the dev branch. #8 is all we need.

brockfanning’s picture

brockfanning commented
Status: Active » Reviewed & tested by the community

#8 is a simple patch, makes sense, and it works. I feel this is ready to be committed.

rgristroph’s picture

rgristroph commented

I'm also now incorporating this patch ( #8 ) on a live site. It seems RTBC is justified and it ought to get committed.

eric_a’s picture

eric_a commented
Version: 7.x-1.x-dev » 7.x-3.x-dev