Closed (fixed)
Project:
Chaos Tool Suite (ctools)
Version:
8.x-1.x-dev
Component:
Exportables
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 May 2012 at 16:48 UTC
Updated:
4 Jan 2014 at 02:05 UTC
Jump to comment: Most recent
Comments
Comment #1
damiankloip commentedTag.
Comment #2
dawehnerIt is marked as being in code, but not really in the database is that intended? Previously it seemed to be overridden
shouldn't it be now?
Comment #3
dawehnerThe rest looks fine and is a real great improvement in terms of readability of the code.
Comment #4
damiankloip commenteddawehner, thanks!
In #2 the exportables will be loaded from the database and ->isInDatabase() will be set then, if a default exists ->isInCode() will be set in the code you pasted above. Is that what you mean?
I am not sure if the export type is staying at the moment. They are all commented out currently. I guess that's a question for merlinofchaos!
Comment #5
dawehnerThe converting to id() itself looks perfect, lets do the mentioned problem in another issue.
Comment #6
damiankloip commentedThanks dawehner, committed: http://drupalcode.org/project/ctools.git/commit/d412252