Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.! :)
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 1599004-8.patch | 904 bytes | anavarre |
| #6 | 1599004-6.patch | 904 bytes | anavarre |
| #4 | 1599004-4.patch | 883 bytes | BrockBoland |
| #1 | 0001-Issue-1599004-by-ericduran-Added-support-github.patch | 751 bytes | ericduran |
Comments
Comment #1
ericduran CreditAttribution: ericduran commentedHere you go. No icons attached, I'll leave it to someone else to find the icons.
Comment #2
q0rban CreditAttribution: q0rban commentedThanks, once you have icons we can add this. Also, if you have no intention of creating icons, you can always use the follow API to add your own networks.
Comment #3
ericduran CreditAttribution: ericduran commented@q0rban yea, but I figured this is a generic enough network that it would be a good addition to the module.
Comment #4
BrockBoland CreditAttribution: BrockBoland commentedThe Paul Robert Lloyd icon set already has a Github icon. Not sure what to do about the others; the two sizes of WPZOOM are available here, but don't include Github:
http://speckyboy.com/2011/08/24/50-social-media-bookmarking-icon-sets-20...
This patch just styles the Github icon when using the Paul Robert Lloyd icons.
Comment #5
anavarreConfirmed that Paul Lloyd's Github icon works fine on a test site.
Comment #6
anavarreSince the patch in #5 was posted, there were a few changes with the module's files so here's a new patch to make it up-to-date with 7.x-2.x
Comment #7
anavarreComment #8
anavarreSeems that 7.x-2.x has slightly changed.
Patch needs icons/paulrobertlloyd32/icon-github.png to be available.
Comment #9
AstonVictor CreditAttribution: AstonVictor as a volunteer and at DevBranch commentedI'm closing it because the issue was created a long time ago without any further steps.
if you still need it then raise a new one.
thanks