Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in unicode.test over to PSR-0.

CommentFileSizeAuthor
#3 1598616.patch1.03 KBrobloach
#1 1598616.patch1.27 KBrobloach

Comments

robloach’s picture

robloach
he/him
commented
Status: Active » Needs review
StatusFileSize
new 1598616.patch1.27 KB
aspilicious’s picture

aspilicious commented

In the other conversions I left the "UnitTest" part to make it clear what the unit tests are and what the function tests are in a list.

I would like to be consistent.
Are there reasosn to change this in this case?

robloach’s picture

robloach
he/him
commented
StatusFileSize
new 1598616.patch1.03 KB

I'm fine with either!

Niklas Fiekas’s picture

Niklas Fiekas commented
Status: Needs review » Reviewed & tested by the community

I checked that indeed the class was previously named UnicodeUnitTest, so no rename needs to happen there. Also we do not need lower thresholds for rename detection. Good to go - thanks, Rob Loach!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks! This one is committed to Drupal 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.