I guess the main points for review on this are:

Do we just pass the $data variable straight to the callback as this patch does now (and 7.x does)?

The default code to populate default values is new.

CommentFileSizeAuthor
#5 1598060-5.patch1.23 KBdamiankloip
#2 1598060-2.patch810 bytesdamiankloip
ctools-exportables-controller-create-8.x.patch1020 bytesdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Title: Create method for DatabaseExportableController » create method for DatabaseExportableController
damiankloip’s picture

damiankloip commented
StatusFileSize
new 1598060-2.patch810 bytes

Here is an updated version without the function callback calls.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work 
+++ b/lib/Drupal/ctools/DatabaseExportableController.phpundefined
@@ -310,7 +310,16 @@ class DatabaseExportableController extends ExportableControllerBase {
+  public function create(array $data = array()) {

That changes the function signature, so it should also be changed in ExportableControllerInterface.

Also, any thought to changing CToolsExportableTestCase::testExportable() to use create() now?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

On second thought, replacing calls to new $this->info['exportable class'] can be a followup. But the interface definitely needs fixing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 1598060-5.patch1.23 KB

With the interface sig change

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

This is easy enough to just push!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.