Add editing of transition speed in/out [#1597762]

Problem/Motivation

The fade transition isn't great, the speed in/out parameters in jquery.cycle lessen this somewhat by smoothing out the sudden 'pop-in' of images.

Proposed resolution

Patch attached. Adds (optional) speed in/out fields to the field settings and sets these parameters in jquery.cycle's options variable if they're set.

Remaining tasks

Reviews needed.

User interface changes

Two new fields 'speed in' and 'speed out' in the field settings form.

API changes

None.

Comment	File	Size	Author
#3	field_slideshow-speed_in_out-1597762-3.patch	3.94 KB	torpy
	field_slideshow-speed_in_out-0.patch	4.04 KB	torpy

Comments

Comment #1

torpy commented 24 May 2012 at 00:55

Status:

Active

» Needs review

Comment #2

idflood commented 24 May 2012 at 07:03

Thanks for this patch, it looks really good. I've still not tested it but I have a little question.

Is there any reason why you use the 2 !empty(...) at the end of the patch? Looking at the code it seems that the default value is '' so it should work by simply assigning the variable, or did I missed something?

'#speed_in'             => $settings['slideshow_speed_in'],
// instead of
'#speed_in'             => (!empty($settings['slideshow_speed_in'])) ? $settings['slideshow_speed_in'] : '',