Off-shoot of #1593058: Remove system.info's files[] entry, move actions.test over to PSR-0. Moves the tests over to modules/system/lib/Drupal/system/Tests/Actions/*.

CommentFileSizeAuthor
#10 1597630-find-copies-harder-10.txt8.12 KBNiklas Fiekas
#8 1597630.patch6.92 KBrobloach
#5 1597630.patch6.53 KBrobloach
actions-psr0.patch6.52 KBrobloach

Comments

robloach’s picture

robloach
he/him
commented
Issue tags: +PSR-0

tag

robloach’s picture

robloach
he/him
commented
Status: Needs review » Needs work

Move it to simpletest/lib.

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review

@Berdir

We just moved them from simpletest to system, do you really want to revert that? See http://drupal.org/node/1540510

Back to needs review!

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work 
+++ b/core/modules/system/lib/Drupal/system/Tests/Actions/LoopTest.phpundefined
@@ -0,0 +1,72 @@
+ * @file Definition of Drupal\system\Tests\Actions\LoopTest.

There should be a newline after @file

6 days to next Drupal core point release.

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 1597630.patch6.53 KB

Thanks!

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Rdy (if bot comes back green)

aspilicious’s picture

aspilicious commented
Status: Reviewed & tested by the community » Needs work

You forgot to remove the action.test line in system.info!
Whoops!

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 1597630.patch6.92 KB

Oops!

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
Niklas Fiekas’s picture

Niklas Fiekas commented
StatusFileSize
new 1597630-find-copies-harder-10.txt8.12 KB

RTBC seconded. Here's also a diff with lower renaming detection thresholds, as sun suggested, showing that almost everything is coming from actions.test 1:1.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

This has been committed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.