Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The field_test module can be found in core/modules/field/test.
Where should we place the class?
field/lib/Drupal/field_test/ClassName
Or somewhere else?
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 1594466-entity-controller-12.patch | 6.3 KB | aspilicious |
| #10 | 1594466-entity-controller-10.patch | 6.12 KB | aspilicious |
| #8 | 1594466.patch | 4.1 KB | robloach |
| #7 | 1594466.patch | 4.12 KB | robloach |
| #4 | 1594466-test-entity-controller-4.patch | 5.83 KB | aspilicious |
Comments
Comment #1
aspilicious commentedCan this work?
Comment #2
aspilicious commentedOk this works, is this ok? Or should we place it inside:
field/tests/field_tests/lib/Drupal/field_test/ClassNameComment #3
robloachSince the class is part of the field_test module space, should it than live at:
core/modules/field/tests/lib/field_test/Drupal/field_test/TestEntityBundleController ?
Comment #4
aspilicious commentedLets try this one
Comment #6
aspilicious commentedApparantly the field_test module wasn't encapsulated yet in its own module. So I moved the files found in field/tests to field/tests/modules/field_test
This also makes this directory future proof and made it easier for me to create the field_test namespace
Comment #7
robloachBelieve it's missing an update to 'controller class' => 'TestEntityBundleController'? Also, probably still need that files definition.
Comment #8
robloachWrong namespace.
Comment #10
aspilicious commentedShould work...
Comment #12
aspilicious commentedThis?
Comment #13
robloachExcellent!
Comment #14
catchSorry I'm confused - don't we need to convert this to an Entity subclass instead? The old controller classes are going to disappear very soon. I don't mind committing this one just to finish off the PSR-0 conversion but wanted to check.
Comment #15
robloachSwitching to an Entity sub-class is probably the right direction for TestEntityBundleController, but also kind of out of scope for this issue. Once the files are cleaned up with PSR-0 we could easily re-evaluate how this entity controller test is accomplished. We could also remove it quite easily later on, when the controller classes disappear too.
This issue is simply to PSR-0 it. I'm going to stick this back to RTBC if the test-bot still likes it.
Comment #16
robloach#12: 1594466-entity-controller-12.patch queued for re-testing.
Comment #17
robloachComment #18
catch#12: 1594466-entity-controller-12.patch queued for re-testing.
Comment #20
robloachIt looks like this was committed yesterday :-) .
Comment #21
l008 commentedI feel a little bit confused. [img]http://www.uukk.info/uukk.gif[/img]
Comment #22
fagoI've opend #1616930: Fix the field_test entity type for fixing the entity type.