As an editor I want to reject a translation and allow the translator to improve his work in order to maintian text quality.

CommentFileSizeAuthor
#4 reject-nativy-1594416-4.patch24.09 KBberdir
#1 tmgmt-1594416-1.patch24.54 KBcorvus_ch

Comments

corvus_ch’s picture

corvus_ch commented
StatusFileSize
new tmgmt-1594416-1.patch24.54 KB

Work in progress. I post here, for I can not continue with this for the next weeks.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

Just want to see what the test bot has to say about it.

Status: Needs review » Needs work

The last submitted patch, tmgmt-1594416-1.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new reject-nativy-1594416-4.patch24.09 KB

Ok, this should pass.

Was quite a nasty problem but once I've seen it, rather obvious.

tmgmt_ensure_keys_array('') resulted in array(0 => '') instead of array(), so the empty($key) was FALSE. Which in turn meant that nothing was saved anymore because it then tried array_shift() on that, key 0 didn't exist and it didn't anything.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Going to open a follow-up issue to add tests for the reject and approve functionaliy (a small part is already tested in the new permission tests), commited this patch. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.