Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
file.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 May 2012 at 09:56 UTC
Updated:
29 Jul 2014 at 20:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
aspilicious commentedPostponing on the file entity stuff
Comment #2
berdirThe file entity patch is now commited, yay!
Comment #3
aspilicious commentedLets try...
Comment #4
robloach#3: 1594254-file-tests-psr0-3.patch queued for re-testing.
Comment #5
aspilicious commented#3: 1594254-file-tests-psr0-3.patch queued for re-testing.
Comment #6
robloachLooks great! One question though.....
Should FileFieldTestBase be an abstract class? I see some assertions in it, but does it make sense for a TestBase class to have assertions? If we want SimpleTest to avoid testing this TestBase, then we'd want to make it abstract.
I could be wrong here though, as I'm not perforectly familiar with the file field tests.
Comment #7
aspilicious commentedOnly functions starting with "test" are run. So it doesn't matter if I make this abstract or not...
I can do it if you insist ;)
Comment #8
robloachIt wasn't an abstract class before, so I see no need :-) . RTBC!
Comment #9
aspilicious commentedNeeds a one line reroll based on this diff: http://drupalcode.org/project/drupal.git/commitdiff/57ab8a546537dab6e4cb...
Comment #10
aspilicious commentedComment #11
robloachThis rebase work?
Comment #12
aspilicious commentedSame number of test classes, the patch is updated. So yeah it worked!
Comment #13
webchickCommitted and pushed to 8.x. Thanks!