Comments

aspilicious’s picture

Status: Active » Postponed

Postponing on the file entity stuff

berdir’s picture

Status: Postponed » Active

The file entity patch is now commited, yay!

aspilicious’s picture

Status: Active » Needs review
StatusFileSize
new114.36 KB

Lets try...

robloach’s picture

Issue tags: -PSR-0

#3: 1594254-file-tests-psr0-3.patch queued for re-testing.

aspilicious’s picture

Issue tags: +PSR-0

#3: 1594254-file-tests-psr0-3.patch queued for re-testing.

robloach’s picture

Looks great! One question though.....

+++ b/core/modules/file/lib/Drupal/file/Tests/FileFieldTestBase.phpundefined
@@ -0,0 +1,228 @@
+/**
+ * @file
+ * Definition of Drupal\file\Tests\FileFieldTestBase.
+ */
+
+namespace Drupal\file\Tests;
+
+use Drupal\simpletest\WebTestBase;
+
+/**
+ * Provides methods specifically for testing File module's field handling.
+ */
+class FileFieldTestBase extends WebTestBase {

Should FileFieldTestBase be an abstract class? I see some assertions in it, but does it make sense for a TestBase class to have assertions? If we want SimpleTest to avoid testing this TestBase, then we'd want to make it abstract.

I could be wrong here though, as I'm not perforectly familiar with the file field tests.

aspilicious’s picture

Only functions starting with "test" are run. So it doesn't matter if I make this abstract or not...
I can do it if you insist ;)

robloach’s picture

Status: Needs review » Reviewed & tested by the community

It wasn't an abstract class before, so I see no need :-) . RTBC!

aspilicious’s picture

aspilicious’s picture

Status: Reviewed & tested by the community » Needs work
robloach’s picture

Status: Needs work » Needs review
StatusFileSize
new82.4 KB

This rebase work?

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Same number of test classes, the patch is updated. So yeah it worked!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.