I opened issue with Aloha module here #1593642: Compability with Panels IPE. Would it be possible to take a look at this issue and suggest Aloha maintainers most obvious places where to look for solutions to make their module compatible. I think that would help them a little. Thanks.

CommentFileSizeAuthor
#5 ctools-modal.js-1593652-3.patch491 bytesmuhleder
#3 ctools-modal.js-1593652#3.patch491 bytesmuhleder

Comments

henrijs.seso’s picture

henrijs.seso commented
Title: Compability of Aloha and IPE, small assistance needed » Compability of Aloha and modal.js, small assistance needed
Project: Panels » Chaos Tool Suite (ctools)
Version: 7.x-3.x-dev » 7.x-1.x-dev
Component: In-Place Editor (IPE) » Modal

Moving to more proper place due to latest discoveries.

henrijs.seso’s picture

henrijs.seso commented
Title: Compability of Aloha and modal.js, small assistance needed » Make modal.js more robust
Category: support » bug

There is a problem in modal.js in for loop, line for (var i in $(target).parents().get()) {. It stops working if some other module requires ExtJs (for example, Aloha editor) with which Array prototype has a method 'remove' which gets in loop and brakes js.

See more at #1593642: Compability with Panels IPE comment #13.

muhleder’s picture

muhleder commented
Status: Active » Needs review
StatusFileSize
new ctools-modal.js-1593652#3.patch491 bytes

Here's a patch which should fix it. You will probably see the same issue with other libraries which extend the array prototype, eg prototype.js

http://www.prototypejs.org/api/array

Personally I don't think these libraries should be doing this, but anyway..

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work

Naming the patch with a # prevents me from opening it. Can you reupload it?

muhleder’s picture

muhleder commented
StatusFileSize
new ctools-modal.js-1593652-3.patch491 bytes

Sure, sorry about that.

henrijs.seso’s picture

henrijs.seso commented

#5 fixes particular issue with ExtJs. Well done!

(Shame I could not figure it out myself even with tutorial, so that's how you iterate through numeric keys...)

henrijs.seso’s picture

henrijs.seso commented
Status: Needs work » Needs review
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented

availability_calendars use also Array.prototype, which cost me hours to understand, why on earth works my modal window on this page but not this page :D. now I know it.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

I think there's more then one place with wrong enum for properties.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.