Comments

aspilicious’s picture

Status: Active » Needs review
StatusFileSize
new74.58 KB
Tor Arne Thune’s picture

Status: Needs review » Needs work
diff --git a/core/modules/poll/lib/Drupal/poll/Tests/PollJSAddChoiceTest.php b/core/modules/poll/lib/Drupal/poll/Tests/PollJSAddChoiceTest.php

+++ b/core/modules/poll/lib/Drupal/poll/Tests/PollJSAddChoiceTest.phpundefined

@@ -0,0 +1,51 @@
+<?php
+
+/**
+ * @file
+ * Definition of Drupal\poll\Tests\PollJSAddChoiceTest.
+ */
+
+namespace Drupal\poll\Tests;
+
+use Drupal\simpletest\WebTestBase;
+
+/**
+ * Test adding new choices.
+ */
+class PollJSAddChoiceTest extends WebTestBase {

Should this be PollJsAddChoiceTest?

Other than that this looks good.

robloach’s picture

Status: Needs work » Reviewed & tested by the community

The old one was class PollJSAddChoice, so PollJSAddChoiceTest.php seems like the right spot for it. RTBC! We could make a follow up to clean up the definition or name if we wanted.

Tor Arne Thune’s picture

Sorry, I meant the JS acronym capitalization. Shouldn't it be Js in CamelCase?

robloach’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new74.58 KB

Does just switching the case work? Lazy patch is lazy :-) .

Tor Arne Thune’s picture

Status: Needs review » Reviewed & tested by the community

Looks good! That's what I meant.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.