views_handler_field_field::post_execute(&$values), line 615-616 in 7x-3.x 6891ceb
When processing result $values for entities by type, the loop does not check if isset($object->{$this->aliases['entity_type']}) before using it to determine entity type.

This condition could occur if a style handler removes the fields in its implementation of the query() method to force a summary style view.

CommentFileSizeAuthor
#13 views-1591678-13.patch981 bytestim.plunkett
#8 1591678-8.patch981 bytesdamiankloip
#1 views_handler_field_field--ensure-entity_type-isset-1591678.patch890 bytesrecrit
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

recrit’s picture

recrit CreditAttribution: recrit commented
FileSize
views_handler_field_field--ensure-entity_type-isset-1591678.patch890 bytes

The attached patch adds the check.

recrit’s picture

recrit CreditAttribution: recrit commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Fixed

This patch looks fine, lets get it into 7.x-3.x and 8.x-3.x

ali_b’s picture

ali_b CreditAttribution: ali_b commented

hm, after update, iam getting errors:

Notice: Undefined index: entity_type in views_handler_field_field->post_execute() (line 615 of .../sites/all/modules/views/modules/field/views_handler_field_field.inc).

somatics’s picture

somatics CreditAttribution: somatics commented

I'm getting floods of exactly the same error as #4 (down to the line# 615) on my site.

johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented
Status: Fixed » Needs work

Same error as #4 occurs, with -dev version from 29-05-2012.

IMO it needs an extra check:
if (isset($this->aliases['entity_type']) && ...

jddeli’s picture

jddeli CreditAttribution: jddeli commented

Same error as #4

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
FileSize
1591678-8.patch981 bytes

I think @johnv is right. Unfortunately isset() can't check the existence of both at the same time.

akoepke’s picture

akoepke CreditAttribution: akoepke commented

This is still generating errors when I test it. It looks like these errors are because you are using || instead of &&.

if (isset($this->aliases['entity_type']) || isset($object->{$this->aliases['entity_type']})

In this first part of the condition it will still run isset($object->{$this->aliases['entity_type']}) even if $this->aliases['entity_type'] is not set. Even though the second check is done inside an isset that is checking $object and so the $this->aliases['entity_type'] reference still creates the notice.

Since the second condition requires the first to be true then using && seems to make sense.

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
CreditAttribution: jeffschuler commented

The change in #9 removes the notices for me.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Yep.

patoshi’s picture

patoshi CreditAttribution: patoshi commented

#8 + #9 solves the issue. its just a one line change with the addition of &&

screenshot http://img705.imageshack.us/img705/2301/croppercapture197.jpg

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: Unassigned » dawehner
FileSize
views-1591678-13.patch981 bytes

Oops, missed that this wasnt a finished patch.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Looks good to me, apologies all for the flawed logic in #8 :)

Jawi’s picture

Jawi CreditAttribution: Jawi commented

works for me with views 7.x-3.3+169-dev

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Reviewed & tested by the community » Fixed

This looks perfect, thanks for the effort!

Committed to 7.x-3.x and 8.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.