ILS currency symbol should be placed 'after'.

See for reference:
http://www.drupalcommerce.org/node/3070

Comments

rszrama’s picture

Can you provide a full example of how the currency will look when formatted properly?

rszrama’s picture

Version:7.x-1.3» 7.x-1.x-dev
Priority:Minor» Normal
Status:Active» Needs review

Based on your example in the linked thread and what appears on http://www.gadgetshop.co.il/, I think the currency code should actually appear before the number. This is the way it gets put in the HTML, even if from an RTL standpoint it's "after" the number. I'm going to update the currency array to:

<?php
   
'ILS' => array(
     
'code' => 'ILS',
     
'symbol' => '₪',
     
'name' => t('Israeli New Sheqel'),
     
'numeric_code' => '376',
     
'symbol_placement' => 'before',
     
'code_placement' => '',
     
'minor_unit' => t('Agora'),
     
'major_unit' => t('New Shekels'),
    ),
?>

123.45 will be formatted as ₪123.45.

rszrama’s picture

Actually, should Sheqel not be Shekel, too?

amitaibu’s picture

Status:Needs review» Reviewed & tested by the community

Sheqel => Shekel.

As in, "Hi Ryan, I'll give you 10 Shekels if you write committed in Hebrew :) "

rszrama’s picture

Status:Reviewed & tested by the community» Fixed

lol Thanks for the look, Amitai. ; )

Unfortunately, my Herbrew vocabulary is quite rust. Google gives me מחויב for committed, but it might be better to use נשוי. : P

Committed!

Automatically closed -- issue fixed for 2 weeks with no activity.