Closed (fixed)
Project:
Drupal Code Sniffer
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 May 2012 at 15:20 UTC
Updated:
1 Jun 2012 at 16:30 UTC
While using this in conjucntion with PAReview to check some CSS, I've noted that lines containing CSS comments immediately following a closing brace causes Drupal_Sniffs_CSS_ClassDefinitionOpeningBraceSpaceSniff to (incorrectly) return errors, despite a single newline of the correct format being used. I have already confirmed that it is formatted correctly using a hex editor.
I attach a test case that returns the following errors:
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
7 | ERROR | Expected exactly one new line after opening brace of class
| | definition
12 | ERROR | Expected exactly one new line after opening brace of class
| | definition
18 | ERROR | Expected exactly one new line after opening brace of class
| | definition
25 | ERROR | Expected exactly one new line after opening brace of class
| | definition
30 | ERROR | Expected exactly one new line after opening brace of class
| | definition
35 | ERROR | Expected exactly one new line after opening brace of class
| | definition
40 | ERROR | Expected exactly one new line after opening brace of class
| | definition
--------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| baseline.txt | 662 bytes | alexiswatson |
Comments
Comment #1
klausiThanks for reporting, fixed: http://drupalcode.org/project/drupalcs.git/commit/4e8cc8c