Modifying content substracts my point & add someone else' point

I'm experiencing a similar issue.

Upgraded to Drupal v5.1 over the weekend and now when I approve moderated comments, the poster loses his/her 5 points and I am awarded 5 points.

Kevin

Setting this to critical.

I have a wiki Drupal site and any time another user edits a wiki page that a different user created it will take the 30 points away from the creator and transfer it to the editor. I do not seem to have a problem with the comments though.

I was able to duplicate the behavior I was seeing (with comments) on a fresh install.

It appears to be related to the "preview" step in the approval/moderation process.

If I go to the list of comments pending approval and tick the checkbox next to them and approve the entire list, userpoints works as advertised.

But, if I open a comment on that list and approve it using the radio button under the "administer" heading, two entries are entered in the userpoints_txn table ... one that deducts the user's points and another that gives (what appears to be a random user) 5 points. Sometimes that user is me, sometimes it's another user, sometimes it's an anonymous user.

we are having problems with points being subtracted when someone edits a comment.

i second this and add the information that a random/changing user seems to get the points. today it is a user that doesn't even exist in the users database anymore (he got deleted).

Any help would be appreciated.

I changed the userpoints_comment() function in the userpoints.basic module to something that appears to have solved the problem.

It appears that the author was trying to reassign points in cases where the author of a comment was changed by the administrator. I probably have not interpreted the author's intent (please clarify if you have time) but I didn't see a case where a comment's author would be changed so I removed this code and things appear to be working as advertised.

I changed these lines (starting at approximiately line 110) ...
From this (before edits):

function userpoints_comment($comment, $op) {
  global $user;
  static $orig_uid;

  $points = variable_get(USERPOINTS_POST_COMMENT, 0);
  switch($op) {
    case 'insert':
      userpoints_userpointsapi('points', $points, $user->uid, 'post comment');
      break;
    case 'delete':
      $points = -$points;
      userpoints_userpointsapi('points', $points, $comment->uid, 'post comment');
      break;
    case 'moderate':
      $points = variable_get(USERPOINTS_MODERATE_COMMENT, 0);
      userpoints_userpointsapi('points', $points, $comment->uid, 'moderate comment');
      break;
    case 'form':
      $orig_uid = $comment['uid']['#value'];
    case 'update':
      if ($orig_uid != $comment['uid']['#value']) {
        // Add to the new comment owner
        userpoints_userpointsapi('points', $points, $comment['uid']['#value'], 'post comment');

        // Subtract from the original comment owner
        $points = -$points;
        userpoints_userpointsapi('points', $points, $orig_uid, 'post comment');
      }
      break;
  }
}

To this (after edits):

function userpoints_comment($comment, $op) {
  global $user;
  static $orig_uid;

  $points = variable_get(USERPOINTS_POST_COMMENT, 0);
  switch($op) {
    case 'insert':
      userpoints_userpointsapi('points', $points, $user->uid, 'post comment');
      break;
    case 'delete':
      $points = -$points;
      userpoints_userpointsapi('points', $points, $comment->uid, 'post comment');
      break;
    case 'moderate':
      $points = variable_get(USERPOINTS_MODERATE_COMMENT, 0);
      userpoints_userpointsapi('points', $points, $comment->uid, 'moderate comment');
      break;
    case 'form':
      $orig_uid = $comment['uid']['#value'];
    case 'update':
      break;
  }
}

I also have this problem. Could the module's maintainer confirm that it is ok to apply code change in #7, please. I do not want to break some other functionalities.

kmillecam

Can you submit this as a patch to the latest 5.x?

Here's a patch against userpoints-5.x-2.14 that includes the changes listed above.

Kevin

I applied kmillecam's patch above.

However, this addresses only comments. Not sure if it will address other issues that are reported in this thread.

To everyone in this issue: please way for 12 hours from the time of this comment, then download the 5.x-dev tarball and see if it solves your problem. Report back what you find. If it solves them, then I will create a 5.x-2.15 official release.

i confirm suggested changes fixed the problem.

i got 5.2 drupal with last stable userpoints and got this bug fixed by this patch

thank you! :)

appears to be squashed.