When a user views the project summary page but is not logged in, it is not indicated to the user that if he was logged in he could create a new issue (support, bug, feature request). This is in contrary to several core modules (forum, comment, etc.) which do make this more obvious to the user.

The attached patch adds a "Login or register" type link in the Support section of the project summary page when the user is not logged in.

This patch depends on a similar patch in project_issue being applied. See that issue at http://drupal.org/node/102395

Comments

dww’s picture

Status: Needs review » Needs work

Extra spaces after the end of the else clause.

aclight’s picture

Status: Needs work » Needs review

Extra spaces after the end of the else clause.

I don't understand what you mean? Are you saying there ARE extra spaces or that there SHOULD be extra spaces? I don't see any extra spaces.

aclight’s picture

Status: Needs review » Needs work

Ok..I think I understand what you mean by all the whitespace complaints.

Are you talking about this:

+    else {
+      $links[] = theme('project_issue_create_forbidden', $node->uri);
+    }
+****

Where above I've replaced 4 space chars with 4 * chars?

If that's what you're talking about, those are popping up because my text editor is auto-indent, and so it's indenting for me but then I just leave the line blank.

I'm sure this is editor dependent, but how do other people deal with this? Do they just not use auto indent, or are some editors smart about this and don't actually do the indentation until something is typed on the line?

Or, is there a flag that I can pass to diff that will cause it to drop the spaces?

Sorry for having patches with extra whitespace--I didn't realize it was doing that.
AC

aclight’s picture

Status: Needs work » Needs review
StatusFileSize
new668 bytes

patch with 4 spaces removed

drewish’s picture

is theme_project_issue_create_forbidden() defined some place?

aclight’s picture

dww’s picture

Status: Needs review » Postponed

http://drupal.org/node/102395 needs work, so for now, this is postponed.

aclight’s picture

Status: Postponed » Needs review

Now that http://drupal.org/node/102395 has been committed, I think this is ready to go.

I checked and it still applies (though there is an offset).

dww’s picture

Status: Needs review » Fixed

Reviewed, tested, committed to HEAD, and installed on d.o. Thanks!

Anonymous’s picture

Status: Fixed » Closed (fixed)