When you enable a field for indexing, it doesn't show up in the Facets tab until you clear cache. The reverse is also true, in that when you disable a field for indexing the facet is not removed from the list until the cache is cleared. This is due to Facet API's caching of hook_facetapi_facet_info() implementation as discussed as mentioned at #1400136: Facets are not removed / added from the list when a field's indexing status changes. The solution is to add a submission handler that clears the appropriate caches when the search_api_admin_index_fields() form is submitted.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | facet-info-cache-invalidation-1569874-2.patch | 992 bytes | cpliakas |
| #1 | facet-info-cache-invalidation-1569874-1.patch | 984 bytes | cpliakas |
Comments
Comment #1
cpliakas commentedThe attached patch adds a form submission handler and clears the appropriate caches.
Comment #2
cpliakas commentedSame patch, fixed form alter docblock.
Comment #4
cpliakas commentedHm, tests are passing locally. Let's try again?
Comment #5
cpliakas commented#2: facet-info-cache-invalidation-1569874-2.patch queued for re-testing.
Comment #7
drunken monkeyThanks a lot for the patch! Didn't realise Facet API was now doing caching, as you previously opposed it so fervently. ;)
Your patch looks good, don't be out off too much by the test bot's rejecting it. I already removed that particular assertion which inexplicably always failed for the online test bot. The testing suite seems to have some problem with messages not being displayed sometimes. I already reported it, although it's of course been ignored ever since.
Aaaaanyways, thanks again for the patch! Committed.