Closed (fixed)
Project:
Apache Solr Search
Version:
6.x-3.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 May 2012 at 00:13 UTC
Updated:
9 Nov 2012 at 15:28 UTC
Jump to comment: Most recent file
Comments
Comment #1
nick_vhThat is odd since the test-bot in drupal.org runs perfectly... I've tested it again and it seems to work. Will see if I can manage to test it through drush.
I would need more info from you, have you tested it through the UI? Does that work?
Comment #2
fearlsgroove commentedHere's a more complete (and useful) stack trace. The error originates in apachesolr_hook_info_alter's call to entity_get_info()
Comment #3
fearlsgroove commentedYes i've tried through both the UI and through drush
Comment #4
fearlsgroove commentedJust putting a try/catch around the entity_get_info call prevents the simpletest crash for me. This issue only started when we updated to 7.14.
Despite allowing the actual test to finish, we still get an error such as:
Recoverable fatal error: Argument 2 passed to SelectQuery::fields() must be an array.. until we clear the cache after running apachesolr tests. I've seen a similar issue in the queue on that, but I wonder if it's related. Note this doesn't require that we run an apachesolr test -- any test will do.
[Edit:] Thanks for the quick reply!
Comment #5
kenorb commentedThe same problem.
Disabling temporary apachesolr, the error disappears.
Comment #6
edb commentedI just ran into the same problem. I dug a little and it looks like this could be the same issue as #1410256: apachesolr_hook_info() calls entity_get_info() which can throw an error when installing using a profile.
For a quick temporary fix it is possible to wrap the call to entity_get_info() in a try-catch block
Line 2172 apachesolr.module
Comment #7
pwolanin commentedDo we really need this code at all?
If we delete it the only downside is that these hooks are not declared to be part of the "group", which is not a well-used feature anyhow.
Comment #8
pwolanin commentedComment #9
nick_vhWe do not use the groups feature so I agree in removing it
Comment #10
nick_vhComment #11
pwolanin commented6.x has this, maybe doesn't need to be changed?
Comment #12
nick_vhRight, closing this.
If this might be problematic for you in the D6, please reopen this issue
Comment #13
nick_vhComment #14
basvredelingSorry I had to reopen this but the current hook_hook_info() implementation creates an error in the trigger module:
The $hooks content should be a multidimensional array. However, currently it returns a string. Which causes a foreach error in /modules/trigger/trigger.module line 173. The $ops tries to process a foreach loop on 'group', but group is a string.
Comment #15
basvredelingForgot to reopen. I agree with comment #9. Let's not use groups in D6 and just remove it.
Comment #16
basvredelingSame goes for facetapi, facetapi_hook_info() btw
Comment #17
nick_vhCan you show us to the api page where it states that this is wrongly defined? Also, please provide us with a patch that removes the thing. Makes it easier for us to commit the change and test if it is ok :)
Comment #18
basvredelingFor hook_hook_info() please refer to both: http://drupal.org/node/375833 and http://api.drupal.org D6 hook_hook_info
Patch to remove hook_hook_info attached.
Same solution crossposted to facetapi issue list: #1701214: Remove backport of hook_hook_info()
Comment #20
nick_vhCommitted to 6.x-3.x. Thanks!