I have a case where occasionally the alias fails to be generated (node title ends up being empty in the token replacement). I would like to act on that event and add some special logic to create my own automatic alias. Attached is a patch that proposes a solution by adding another alter hook as a second chance.

Is there an easier way to do this? If not, would you consider adding this to the module?

Thx!

CommentFileSizeAuthor
#12 1565850-hook-pathauto-alias-alter-D6.patch2.74 KBdave reid
#10 1565850-hook-pathauto-alias-alter.patch3.07 KBdave reid
#5 1565850-hook-pathauto-alias-alter.patch1.23 KBdave reid
#2 pathauto_retry-1565850-2.patch1.24 KBkevin hankens
pathauto_retry_alter.patch1011 byteskevin hankens

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I'm not sure about the feasibility of this. What if instead we allowed you to alter $pattern before token replacement is performed ala hook_pathauto_pattern_alter(&$pattern)?

kevin hankens’s picture

kevin hankens commented
StatusFileSize
new pathauto_retry-1565850-2.patch1.24 KB

Thx for the quick reply! That would be a great fix for me personally. New patch attached for general perusal.

kevin hankens’s picture

kevin hankens commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, pathauto_retry-1565850-2.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 1565850-hook-pathauto-alias-alter.patch1.23 KB

I was thinking something more like this.

kevin hankens’s picture

kevin hankens commented

That could work. If I call token_replace() from within that hook I can test to see if the alias will be empty when it is officially generated. It's a bit of an estimation, but that should be ok.

Plus, I really really like the idea of having more control over the patterns themselves!

kevin hankens’s picture

kevin hankens commented
Status: Needs work » Needs review
kevin hankens’s picture

kevin hankens commented

Just checking back on this one. What is the next step to get this patch in? Do you need more eyeballs on it first?

Thx!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: Allow modules to respond to a failed path creation » Add a hook_pathauto_pattern_alter() that runs before token replacement in pathauto_create_alias()
Assigned: Unassigned » dave reid

Re-titling and preparing for commit.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 1565850-hook-pathauto-alias-alter.patch3.07 KB

Revised final patch.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 7.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

Pushed #10 to 7.x-1.x. Marking as needs to be backported to 6.x-2.x. http://drupalcode.org/project/pathauto.git/commit/fb961c0

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue summary: View changes
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1565850-hook-pathauto-alias-alter-D6.patch2.74 KB

Patch against 6.x-2.x.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #12 to 6.x-2.x. http://drupalcode.org/project/pathauto.git/commit/9678143

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 6.x-2.x-dev » 7.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rudiedirkx’s picture

rudiedirkx commented

Please create a new release. It's been 3 years. It's about time these goodies are actually usable.

rudiedirkx’s picture

rudiedirkx commented

7.x.1.x commit: http://cgit.drupalcode.org/pathauto/commit/?id=fb961c08d49d3974d33014f52...