Set Max width on standard layout setting disappeared after core update to 7.22

CommentFileSizeAuthor
#9 page-max-width.png255.12 KBJeff Burnz

Comments

Jeff Burnz’s picture

Category: bug » support
Status: Active » Postponed (maintainer needs more info)

No it didn't. Maybe you have an issue, in which case a link, login, more information?

psampaz’s picture

Sorry, after drupal core update to 7.14 I mean.
Same thing happened to 3 different websites.

nkleopas’s picture

Same problem happened to me with "Picture Reloaded" and "Sky" theme. After core drupal update (7.14) the "Set a max width" option in the layout settings is no longer visible.

Jeff Burnz’s picture

Title: Set max width disappeared » Set max width disappeared, review all form #states

How odd, I will try running 7.14, normally I run core dev, I am pretty sure I know the issue and updated the title.

Jeff Burnz’s picture

Title: Set max width disappeared, review all form #states » Review all form #states after Drupal 7.14 updates
Project: Pixture Reloaded » AdaptiveTheme
Version: 7.x-2.2 » 7.x-3.x-dev
Component: User interface » Theme Settings
Category: support » bug
Status: Postponed (maintainer needs more info) » Active

Certinaly some of the form #states have been broken, probably most likely due to:

- Form API #states: Fix conditionals to allow OR and XOR constructions.

However, I cannot reproduce this exact instance of the state being broken, meaning, the max width does show when % width is selected for the page width - can you try clearing your sites cache or turning OFF JavaScript aggregation then turning it back on again. See what happens after that, and save your theme settings also.

Jeff Burnz’s picture

I've committed an update to DEV that fixes and changes some of the form #states for sidebars (the ones for smartphone were broken), and made the others better. I still can't reproduce the issue in the OP, not saying its not happening, but its probably an artifact of upgrading on your system - possibly a combination of upgrading Drupal core and the themes, or something along those lines, I tend to think it may well be something with JS aggregation, but I am not sure.

BTW: if you are wondering what all this #states business is about - notice in the form how certain things hide or show depending on what you select? These things are done with something called form states, its part of Drupal core form API, which changed in 7.14.

nkleopas’s picture

Hello Jeff. Tried everything you said. Unfortunately the problem remains.

Jeff Burnz’s picture

Status: Active » Fixed

Tried everything you said. Unfortunately the problem remains.

Like I said, I can't reproduce it, its on your system, without being able to see your site I can't do anything, or there is something you have omitted to tell me, maybe some vital piece of information without which I cannot emulate the conditions you are running under.

Jeff Burnz’s picture

StatusFileSize
new255.12 KB

See the screenshot, this is what I see.

Jeff Burnz’s picture

Status: Fixed » Closed (fixed)

Sorry, I have really really tried to reproduce this and without more information or even access to your site I cant really do much more.

aung_m’s picture

It happens with Drupal 7.14. When I revert back to Drupal 7.12 Set a max width re-appears again!

Jeff Burnz’s picture

The screen shot in #9 is Drupal 7.14, I suspect you need to update your dev version of Adaptivetheme.

Jeff Burnz’s picture

Version: 7.x-3.x-dev » 7.x-2.x-dev
Category: bug » task
Status: Closed (fixed) » Active

Bah, ignore #12, you are using 7.x-2.2, yes this is a problem due to the changes in 7.14 this will break, I am updating the form states to work in 7.14, the new 7.x-2.x version will be out in a few days.

Not really a bug, just need to chase the changes in Drupal core.

Jeff Burnz’s picture

Recent commits updated form states in 7.x-3.x, I found a few inconsistencies in how I was doing this in the layout forms, I need to check my commits if I updated 7.x-2.x yet or not, memory fails me, pretty sure I still need to do this.

progone’s picture

Any updates, I've been having this issue since the 7.14 update was released. I don't see any new updates either.

Jeff Burnz’s picture

7.x-2.x was updated several days ago. Use the dev or wait a bit for a new release, will be a few days or sooner, depends how things go with the final round of clean install tests.

Jeff Burnz’s picture

Status: Active » Fixed

This is definitively fixed now. Just watch out for this issue: #1618288: Standard layout max-width is empty - you forgot to enter a value for the max width!

progone’s picture

Thanks Man, I'm going to try it now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.