Make CommonJavaScriptTestCase faster [#1558706]

Challenge

Given
- the drupalRenderPage() helper class method from the patch in http://drupal.org/node/1279226#comment-5949082
- the knowledge that a DrupalWebTestCase installs an entirely new Drupal site for every single test* method in a test case
When looking at CommonJavaScriptTestCase and realizing that none of the gazillion test methods needs a completely fresh Drupal site.
Then
- refactor the test methods in CommonJavaScriptTestCase so there is only one test method (but retaining the test method comments as inline comments)
- merge the new CommonJavaScriptDefaultsTestCase test case into the former (if it exists already)
- get the patch committed to Drupal 8
- backport the patch to Drupal 7.

Comment	File	Size	Author
#2	1558706_1_js_tests.patch	11.28 KB	cosmicdreams
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

cosmicdreams CreditAttribution: cosmicdreams commented 10 May 2012 at 20:03

Assigned:

Unassigned

» cosmicdreams

Awesome description sun. and it sounds fun. I'll try to do this one tonight.

Comment #2

cosmicdreams CreditAttribution: cosmicdreams commented 11 May 2012 at 05:15

Status:

Active

» Needs review

File	Size
1558706_1_js_tests.patch	11.28 KB

half-way done. Seeing how the tests respond

Comment #3

11 May 2012 at 05:38

Status:

Needs review

» Needs work

The last submitted patch, 1558706_1_js_tests.patch, failed testing.

Comment #4

sun

German

Karlsruhe

CreditAttribution: sun commented 11 May 2012 at 16:28

+++ b/core/modules/system/tests/common.test
@@ -1135,23 +1134,20 @@ class CommonJavaScriptTestCase extends WebTestBase {
   function tearDown() {
     // Restore configured value for JavaScript preprocessing.
-    $config = config('system.performance');
-    $config->set('preprocess_js', $this->preprocess_js);
-    $config->save();
+    config('system.performance')
+      ->set('preprocess_js', $this->preprocess_js)
+      ->save();

This restore of config can be entirely removed.

+++ b/core/modules/system/tests/common.test
@@ -1214,79 +1198,46 @@ class CommonJavaScriptTestCase extends WebTestBase {
+    // Test adding a JavaScript file with a different group.
...
+    // Test adding a JavaScript file with a different weight.

Each new test needs to start with a reset, so previous drupal_add_js() calls do not interfere with new ones.

It would be a good idea to add a custom resetJS() method to this test, which performs the reset, so it can possibly be easily adjusted in one place later.