Closed (fixed)
Project:
AdaptiveTheme
Version:
7.x-3.x-dev
Component:
CSS/HTML
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Apr 2012 at 17:53 UTC
Updated:
6 May 2012 at 18:50 UTC
This is a very trivial problem, but I figured maybe it would help later.
I use a CSS editor (TopStyle) and one of it's features common with other editors is it gives a list of all the selectors in a column. I can find the selector, click it, and the editor goes to the code. I noticed that when you comment the CSS code with the comment between the selector, and the open bracket, the helpful column selector won't work.
#site-name /* The name of the website */ {
css goes here;
}If I move the comment to above the CSS selector, it works fine.
By the way, I'm loving the new AT theme. I'm customizing my subtheme for a responsive layout.
Comments
Comment #1
Jeff Burnz commentedHmmm, sounds like a bit of a pain. I think we should support all editors, TopStyle is pretty popular software.
I see no real issue with moving the comments (apart from time), this is the first time I ever tried with this commenting style, normally I would have them above as per normal.
Comment #2
wxman commentedI wouldn't stress over it, I'm sure you're busy. I moved all the ones I had, and yes it is time consuming, but it works fine now. I'm trying out the beta version of TopStyle 5 that includes HTML5 and CSS3. So far it's been great.
Comment #3
Jeff Burnz commentedPushed an update to DEV, so this now fixed, would appreciate a review (give the code some time to propagate to the actual tarball (24 hours), otherwise pull with GIT).
This was good, found a few commenting inconsistencies so was a nice opportunity to clean things up some more.
Comment #4
wxman commentedI'll try to remember to get it tomorrow. Thanks again.
Comment #6
Jeff Burnz commentedCleaning up.