For accessability and seo reasons, img tags should come with alt & title attributes. Patch coming up shortly

CommentFileSizeAuthor
#8 twitter_views_field_handlers.inc-alt_title_for_images.patch1.27 KBHomotechsual
#6 twitter_views_field_handlers.inc-alt_title_for_images.patch1.28 KBHomotechsual
#2 1552164-2-image-viewsfield-alt-title.patch1.06 KBmanuel garcia
#1 1552164-1-image-viewsfield-alt-title.patch1.06 KBmanuel garcia

Comments

manuel garcia’s picture

manuel garcia commented
Status: Active » Needs review
StatusFileSize
new 1552164-1-image-viewsfield-alt-title.patch1.06 KB

The attached patch comming up uses the account name field when pulling the image, and uses it for alt and title attributes in the theme('image') call.

manuel garcia’s picture

manuel garcia commented
StatusFileSize
new 1552164-2-image-viewsfield-alt-title.patch1.06 KB

OOps, last patch doesnt apply properly... try this one.

juampynr’s picture

juampynr commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Needs work

Committed. Thanks.

http://drupalcode.org/project/twitter.git/commitdiff/c7dead5

This needs 'forwardport' to 7.x-3.x.

dddave’s picture

dddave commented
Version: 7.x-3.x-dev » 7.x-6.x-dev
Homotechsual’s picture

Homotechsual commented

How does this sit in the current version? Is it present or does a new patch still need to be provided.

Homotechsual’s picture

Homotechsual commented
Status: Needs work » Needs review
StatusFileSize
new twitter_views_field_handlers.inc-alt_title_for_images.patch1.28 KB

Patch against 7.x dev attached. Will probably need work but works for my environment.

juampynr’s picture

juampynr commented
Status: Needs review » Needs work

There are some unwanted white spaces in the patch. Can you fix them please?

Homotechsual’s picture

Homotechsual commented
StatusFileSize
new twitter_views_field_handlers.inc-alt_title_for_images.patch1.27 KB

Done.

Homotechsual’s picture

Homotechsual commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Status: Needs review » Needs work

Needs a minor fix for Drupal coding standards violations, specifically the indenting is off.

manuel garcia’s picture

manuel garcia commented
Assigned: manuel garcia » Unassigned
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

The last submitted patch, 1: 1552164-1-image-viewsfield-alt-title.patch, failed testing.

The last submitted patch, 2: 1552164-2-image-viewsfield-alt-title.patch, failed testing.

DamienMcKenna queued 8: twitter_views_field_handlers.inc-alt_title_for_images.patch for re-testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Status: Needs review » Needs work

The last submitted patch, 8: twitter_views_field_handlers.inc-alt_title_for_images.patch, failed testing.