Remove obsolete drupal_language_initialize()

It's not just the language system, we should do this with everything!

I think its fare to do it first for languages since we did DI for that first too.

given the goal of this issue we should include the changes to eliminate the use of $GLOBALS for the language system

curious to see how this patch tests.

Looks like it needs a reroll

See if combining this patch with #1539614: Modify language module to use Dependency Injection for language makes this handle the exceptions about language_content better.

Found some $GLOBALS still in use for language dependencies:

Found two more instances of variables that need to use the DI instead of $GLOBALS

In looking at some of the exceptions this is generating I found one code error that I don't know the solution for:

In Language.php, lines 67 - 81 we have this:

// Check if we are to bootstrap the Language system.
      if (!$container->has('language.bootstrap')) {
        // Bootstrap modules should have been loaded when this function is called, so
        // we don't need to tell module_list() to reset its internal list (and we
        // therefore leave the first parameter at its default value of FALSE). We
        // still pass in TRUE for the second parameter, though; in case this is the
        // first time during the bootstrap that module_list() is called, we want to
        // make sure that its internal cache is primed with the bootstrap modules
        // only.
        foreach (module_list(FALSE, TRUE) as $module) {
          drupal_load('module', $module);
          module_invoke($module, $hook);
        }
        $container->set('language.bootstrap', TRUE);
      }

In that code block $hook is undefined. Should it be a string? what should it be? Should we get the value through reflection?

How should we proceed?

I found 5 or 6 more GLOBALS to eliminate. Let's see if this patch score better

#16: 1550866_16_language_di.patch queued for re-testing.

Needs reroll

Updated issue summary.

The bootstrap phase is gone already. The language system is initialized on-demand.

Technically, I don't see why attached patch should not work.

Manually installed d8 in russian, added english and content translation - everything works fine!

+++ b/core/includes/bootstrap.inc
@@ -2009,15 +2009,6 @@ function drupal_installation_attempted() {
- * Initializes all the defined language types and sets the default langcode.
...
-function drupal_language_initialize() {
-  $language_manager = \Drupal::languageManager();
-  $language_manager->init();
-  \Drupal::translation()->setDefaultLangcode($language_manager->getCurrentLanguage()->id);
-}

Seems this $language_manager->init(); obsolete now so filed follow-up #2214057: Remove obsolete LanguageManagerInterface::init() method

+++ /dev/null
@@ -1,15 +0,0 @@
-function language_uninstall() {
-  // Re-initialize the language system so successive calls to t() and other
-  // functions will not expect languages to be present.
-  drupal_language_initialize();
-}
diff --git a/core/modules/language/lib/Drupal/language/Tests/LanguageDependencyInjectionTest.php b/core/modules/language/lib/Drupal/language/Tests/LanguageDependencyInjectionTest.php

I am not sure about this hunk: shouldn't we reset the language manager so language is re-negotiated when needed?

Suppose on uninstall the container rebuild happens, so none-configurable language manager is used

so back to RTBC?

I agree with @andypost, ModuleHandler::uninstall() reboots the kernel + rebuilds the container, which means that LanguageManager is replaced with a new instance already.

hook_modules_uninstalled() is only invoked later on, so a reset in there would actually reset it "twice."

Works for me, thanks :)

Doesn't apply. I'll reroll this now.

easy reroll (automatic 3-way merge, no conflicts).

was a change in context lines:
< \Drupal::setContainer($container);
---
> @@ -376,8 +376,6 @@ function install_begin_request(&$install_state) {
> $container->get('string_translation')
> ->addTranslator($container->get('string_translator.file_translation'));

probably rtbc if green.

Committed/pushed to 8.x, thanks!