Right now, the term context isn't working in site_template, and what I can see it's because the task uses the old context "term" instead of "entity:taxonomy_term".

I've changed all context to the new entity context and created a patch.

CommentFileSizeAuthor
#4 use-entity-context-1550294-4.patch1.48 KBlogaritmisk
#2 use-entity-context-1550294-2.patch614 byteslogaritmisk
#1 use-entity-context-1550294-1.patch3.46 KBlogaritmisk

Comments

logaritmisk’s picture

logaritmisk commented
Status: Active » Needs review
StatusFileSize
new use-entity-context-1550294-1.patch3.46 KB

And the patch.

logaritmisk’s picture

logaritmisk commented
StatusFileSize
new use-entity-context-1550294-2.patch614 bytes

New patch which only fixes this bug, we should maybe create a new issue to update panels_everywhere to the new context standard.

Letharion’s picture

Letharion commented
Assigned: Unassigned » merlinofchaos

Merlin, I think this patch makes sense, and I'm looking over logaritmisk's shoulder and can see that it works, but strangely enough I can't reproduce this problem. Can you take a look? :)

logaritmisk’s picture

logaritmisk commented
Title: Make site_template task use the new entity context » Change term context to the new entity:taxonomy_term in site_template.
StatusFileSize
new use-entity-context-1550294-4.patch1.48 KB

Changed title and fix the rest of the term context in site_template.inc.

merlinofchaos’s picture

merlinofchaos commented

Hm. This should probably actually be fixed in CTools so that the 'term' context ends up created as the proper context instead. I thought I had fixed that. Or maybe I wasn't able to. It's annoying that we're still having issues like this, though.

I know that the 'node' context has a special line in it, 'superceded by' => 'entity:node' that makes all 'node' contexts turn into 'entity:node' contexts.

I wonder why term contexts don't have this.

IRuslan’s picture

IRuslan commented

We still have this problem actual.
That patch fix it from panels_everywhere side.

It works for node, because we have entity type name as one of context's type. And for taxonomy_term it doesn't work, as keyword and entity type name don't match.

b-prod’s picture

b-prod commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

The patch in #4 fixes the issue.

Without the patch, no Taxonomy term context is available from default site template (for example in the relationship list, there is nohing related to a term entity).
With the patch, those expected contexts show up!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks for the patch, and patience.

  • Commit 75ece58 on 7.x-1.x by DamienMcKenna: 
    Issue #1550294 by logaritmisk: Load the correct context on term_view...

  • Commit 05d94b8 on 7.x-1.x by DamienMcKenna: 
    Revert "Issue #1550294 by logaritmisk: Load the correct context on...

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I've (reverted and) committed this one again in order to fix the authorship.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.