Module code should meet Drupal coding standards [#1550070]

Currently the D7 version of the module code doesn't meet Drupal coding standards (the code review throws up a lot of errors).

I've attached a patch that fixes that up, so that the code review report is clean, even on minor.

Comment	File	Size	Author
#4	interdiff-1_4.txt	1017 bytes	urvashi_vora
#4	coding-standard-fixes-1550070-4.patch	39.31 KB	urvashi_vora
#1	audiorecorderfield-coding_standards_fixes-1550070-1.patch	36.82 KB	snyderp

Issue fork audiorecorderfield-1550070

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1550070-module-code-should compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

snyderp commented 27 April 2012 at 06:10

Status	File	Size
new	audiorecorderfield-coding_standards_fixes-1550070-1.patch	36.82 KB

Simple patch to make the module code match drupal coding standards

Comment #2

astonvictor commented 27 August 2018 at 06:21

Issue summary:	View changes
Status:	Active	» Needs work

Still have a lot of CS issues.

audiorecorderfield/sources/recorder.inc:5:4: error - Doc comment short description must end with a full stop
audiorecorderfield/sources/recorder.inc:17:5: error - No space found before comment text; expected "// 'value' => 'filefield_source_recorder_value'," but found "//'value' => 'filefield_source_recorder_value',"
audiorecorderfield/sources/recorder.inc:17:5: error - Inline comments must end in full-stops, exclamation marks, colons, question marks, or closing parentheses
audiorecorderfield/sources/recorder.inc:56:8: error - Array indentation error, expected 6 spaces but found 7
audiorecorderfield/sources/recorder.inc:57:8: error - Array indentation error, expected 6 spaces but found 7
audiorecorderfield/sources/recorder.inc:61:1: error - Expected 1 blank line after function; 2 found
audiorecorderfield/sources/recorder.inc:74:1: error - Expected 1 newline at end of file; 0 found
audiorecorderfield/audiorecorderfield.install:3:1: error - Missing short description in doc comment
audiorecorderfield/audiorecorderfield.install:21:1: error - Expected 1 newline at end of file; 0 found
audiorecorderfield/audiorecorderfield.module:1:1: error - Missing file doc comment
audiorecorderfield/audiorecorderfield.module:1:1: error - End of line character is invalid; expected "\n" but found "\r\n"
audiorecorderfield/audiorecorderfield.module:12:3: error - Inline comments must end in full-stops, exclamation marks, colons, question marks, or closing parentheses
audiorecorderfield/audiorecorderfield.module:13:49: error - Expected 1 space between double arrow and "drupal_get_path"; 2 found
audiorecorderfield/audiorecorderfield.module:13:49: error - Expected 1 space after "=>"; 2 found
audiorecorderfield/audiorecorderfield.module:44:1: error - You must use "/**" style comments for a function comment
audiorecorderfield/audiorecorderfield.module:44:1: error - Expected 1 blank line before function; 0 found
...